Remove Windows static builds#234
Conversation
c7dd6a9 to
ea639ab
Compare
indygreg
left a comment
There was a problem hiding this comment.
As I reviewed all the deleted code, I couldn't help but reflect on how many hours it took to devise those lines of code. Dozens. If not over 100.
It was a bold experiment. But sometimes you can only learn through failure.
Thank you for this PR: it looks great!
|
|
||
| // The -shared and -static parts of the triple are a lie. But the code | ||
| // handles it fine. | ||
| // The -shared part of the triple is a lie. But the code handles it fine. |
There was a problem hiding this comment.
As a potential future followup we can strip the -shared part from the triple. The only reason it is there is to disambiguate from the static builds. Now since there are only dynamically linked builds, there's no need for the label.
I'll file an issue to track this.
There was a problem hiding this comment.
Cool, I can do that too.
Honestly... I guessed as much. There were so many little details here in the static library conversion, |
The docs say that [Windows Static Distributions are Extremely Brittle](https://github.com/astral-sh/python-build-standalone/blob/main/docs/quirks.rst#windows-static-distributions-are-extremely-brittle). However, since #234, Windows static builds no longer exist, making this documentation obsolete. Fixes #597
Summary
This PR removes the Windows static builds from the build and release pipelines. As per #221:
Closes #221.