Avoid infinite loop from non-attribute retreats #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
152fb86 to
c88c5de
Compare
c88c5de to
524321d
Compare
zanieb
approved these changes
Dec 5, 2025
Member
Author
|
Confirmed this does fix the root cause of astral-sh/uv#16937. |
charliermarsh
added a commit
that referenced
this pull request
Dec 6, 2025
zanieb
pushed a commit
to astral-sh/uv
that referenced
this pull request
Dec 6, 2025
## Summary This was reverted due to a hang (#16937) which was then resolved upstream (astral-sh/astral-tl#16).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I don't know if this is the root cause of astral-sh/uv#16937, but it does appear to be a loop introduced in #13.