crates/napi/__test__/index.spec.ts (1)

323-330: LGTM: Test case is well-structured, but could be expanded

The test effectively verifies the basic functionality. Consider adding additional test cases for:

• Empty fields (no attributes)
• Nested JSX elements with multiple fields
• Fields with different names

Example additional test cases:

test('fieldChildren handles empty fields correctly', t => {
  const sg = tsx.parse('const el = <div />')
  const jsxElement = sg.root().find(tsx.kind('jsx_self_closing_element'))!
  const fields = jsxElement.fieldChildren('attribute')
  t.is(fields.length, 0)
})

test('fieldChildren works with nested elements', t => {
  const sg = tsx.parse('const el = <div><span id="1" /><span id="2" /></div>')
  const jsxElement = sg.root().find(tsx.kind('jsx_element'))!
  const fields = jsxElement.fieldChildren('jsx_element')
  t.is(fields.length, 2)
})

Configuration used: CodeRabbit UI
Review profile: CHILL

crates/pyo3/src/py_node.rs (1)

171-180: LGTM! Consider adding docstring.

The implementation follows the established pattern for node traversal methods and correctly maintains the root reference. Consider adding a docstring to document the method's purpose and return type.

Add a docstring similar to this:

+  /// Returns all child nodes that match the given field name.
+  /// 
+  /// # Arguments
+  /// * `name` - The field name to match
+  /// 
+  /// # Returns
+  /// A vector of matching child nodes
   fn field_children(&self, name: &str) -> Vec<SgNode> {

crates/pyo3/tests/test_traversal.py (1)

47-57: LGTM! Consider adding more test cases.

The test effectively verifies the basic functionality of field_children. Consider adding these additional test cases:

Add tests for:

1. Empty case (node with no matching fields)
2. Single field case
3. Nested fields case

Example:

def test_field_children_edge_cases():
    # Test empty case
    source = '<div></div>'
    sg = SgRoot(source, "tsx")
    node = sg.root().find(kind="jsx_element")
    assert node
    attributes = node.field_children("attribute")
    assert len(attributes) == 0

    # Test single field
    source = '<div id="foo"></div>'
    sg = SgRoot(source, "tsx")
    node = sg.root().find(kind="jsx_element")
    assert node
    attributes = node.field_children("attribute")
    assert len(attributes) == 1
    assert attributes[0].text() == 'id="foo"'

    # Test nested fields
    source = '<div><span id="nested">text</span></div>'
    sg = SgRoot(source, "tsx")
    node = sg.root().find(kind="jsx_element")
    assert node
    children = node.field_children("child")
    assert len(children) == 1
    nested_attrs = children[0].field_children("attribute")
    assert len(nested_attrs) == 1
    assert nested_attrs[0].text() == 'id="nested"'

Configuration used: CodeRabbit UI
Review profile: CHILL

crates/pyo3/ast_grep_py/ast_grep_py.pyi (1)

57-57: LGTM! Consider adding docstring type hints.

The method signature follows Python naming conventions and aligns well with existing tree traversal methods. The return type is consistent with other plural methods in the class.

Consider adding docstring type hints for better IDE support:

-    def field_children(self, name: str) -> List[SgNode]: ...
+    def field_children(self, name: str) -> List[SgNode]:
+        """Get all child nodes that match the given field name.
+        
+        Args:
+            name (str): The field name to match
+            
+        Returns:
+            List[SgNode]: List of child nodes matching the field name
+        """
+        ...

Configuration used: CodeRabbit UI
Review profile: CHILL