Skip to content

Feature/#145 ask question from room#267

Merged
mrsimpson merged 65 commits intodevelopfrom
feature/#145-ask-question-from-room
Mar 20, 2018
Merged

Feature/#145 ask question from room#267
mrsimpson merged 65 commits intodevelopfrom
feature/#145-ask-question-from-room

Conversation

@vickyokrm
Copy link
Copy Markdown

@vickyokrm vickyokrm commented Mar 4, 2018 •
edited by mrsimpson
Loading

closes #145 [Enable users to ask questions from an existing chat room]

Reference to previous pull request closed due to inconsistency in the issue with branch name #232

Feature Overview:
To allow users to ask help about a conversation while they are in a chat room.

Motivation:
This feature will enable user to ask more questions in an isolated way which implies the new help request is created in the current conversation context.

Benefits of the solution:

  • Enable users to pro-actively communicate with out being afraid of leaving the chat room in which the user is conversing.

  • Using Assistify as a platform to ask and communicate more intensive.

What has changed/introduced:

  1. A new Message Action so called 'Help' has been introduced shall be used to create help request for a particular message.

  2. The new help request creation feature will prompt user to provide a request title a optional field.

  3. Upon confirmation, a new help request room will be created propagating the experts users and the question/query to the new room.

What is missing:

  • Translation of the texts in Deutsch

  • Code review from reviewer

  • Feedback

[Vigneshwaran Odayappan] and others added 12 commits February 7, 2018 16:02
retrieve chatpal-search submodule from assistify-repo
2029a2b
Merge branch 'feature/0.61' of https://github.com/assistify/Rocket.Chat…
e05d275 
… into feature/0.61
Create help request room implicity from Chat Room
12bd2b5
Includes navigation and Factory instantiation
81cd4a1
Merge branch 'develop' of https://github.com/assistify/Rocket.Chat in…
8ced7e1 
…to feature/#142-ask-question-from-room
removing unwanted files away
d02d130
add new fields to assistify page
3ad5ea2
execute tests with single login
f54ad56
adapting translation texts
61775ec
fixed test and moved to assistify folder
b596e65
Merge branch 'feature/#142-ask-question-from-room' of github.com:assi…
022a207 
…stify/Rocket.Chat into feature/#142-ask-question-from-room
System message with navigation link
f26bd0d
@ghost ghost assigned vickyokrm Mar 4, 2018
@ghost ghost added the progress:working label Mar 4, 2018
@vickyokrm vickyokrm requested a review from ThomasRoehl March 4, 2018 18:23
@ghost ghost assigned ThomasRoehl Mar 6, 2018
@ThomasRoehl
Copy link
Copy Markdown

ThomasRoehl commented Mar 6, 2018

Tests have to be fixed. It still assumes to have the dialog window

ThomasRoehl
ThomasRoehl approved these changes Mar 6, 2018
View reviewed changes
Copy link
Copy Markdown

@ThomasRoehl ThomasRoehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine now.
Tests could be improved, but the main content is covered.

@vickyokrm vickyokrm changed the title [DO NOT MERGE]Feature/#145 ask question from room Feature/#145 ask question from room Mar 6, 2018
@mrsimpson
Copy link
Copy Markdown
Member

mrsimpson commented Mar 7, 2018 •
edited
Loading

image

    "attachments" : [ 
        {
            "title" : "Answer here to help @Vig",
            "title_link" : "http://localhost:3000/request/rolltreppen-3?msg=rk6bsPzqGatyNedio"
        }
    ],

@janrudolph
Copy link
Copy Markdown

janrudolph commented Mar 8, 2018 •
edited
Loading

Review results:

  • Original message will be replaced by bot message.
  • Look and feel of the bot message in the parent channel see above (mrsimpson's comment)
  • The user, which posts the bot message, looks like the user who has posted the question OR the assistify user will do so
  • In the sub-channel, first a bot message indicates, that the new channel is a sub channel of XY and asks the user to help the questioner. Additionally, the bot will ask the users to close the channel once the question has been answered.
  • The original question is posted as second message by the user who asked the question in the parent channel.

@mrsimpson
Copy link
Copy Markdown
Member

mrsimpson commented Mar 16, 2018 •
edited
Loading

Current state of threading (click it, it's a video ;) ):
Click to preview

mrsimpson and others added 21 commits March 18, 2018 18:51
@mrsimpson
minor translations
f75ec01
@mrsimpson
Add separate permission for starting a thread for someone else's message
92f674f
@mrsimpson
remove headlss build in travis
3a6ab48
@mrsimpson
fix tests for threading
09b6a99
@mrsimpson
rename some test objects
cac6999
@mrsimpson
grant more time for the build on travis
f02ed82
@mrsimpson
Don't cache anything in the build-path
5d532c1
@mrsimpson
make travis skip tests only if requested
cb4c146
Code Refactoring and clean-up
6d2edb6
@mrsimpson
Provide support area to smarti from diverse sources supporting the th…
48a7f5a 
…read-requests
@mrsimpson
Merge remote-tracking branch 'origin/feature/#145-ask-question-from-r…
d245a04 
…oom' into feature/#145-ask-question-from-room
@ThomasRoehl
deactivate caching
e03c81f
@ThomasRoehl
reactivate caching
96a1d2c
@mrsimpson
remove all caches for travis
c7c1877
@mrsimpson
merge develop
42c9417
@mrsimpson
Merge branch 'feature/#145-ask-question-from-room' of https://github.…
4db2898 
…com/assistify/Rocket.Chat into feature/#145-ask-question-from-room
@mrsimpson
push chatpal-version
a7f028c
@mrsimpson
Merge remote-tracking branch 'origin/develop' into feature/#145-ask-q…
a818857 
…uestion-from-room
@mrsimpson
handle non-existent statistics (very first start)
41d645c
@mrsimpson
grant more build time to travis - was too close last time
193f1ce
@mrsimpson
provide more stable selection of support_area
9fd3d16
@mrsimpson mrsimpson merged commit d85dbe8 into develop Mar 20, 2018
@ghost ghost removed the progress:working label Mar 20, 2018
@mrsimpson mrsimpson deleted the feature/#145-ask-question-from-room branch March 20, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ThomasRoehl ThomasRoehl ThomasRoehl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ThomasRoehl ThomasRoehl

@mrsimpson mrsimpson

@vickyokrm vickyokrm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make people ask questions - heavyweight threading from every room

4 participants

@vickyokrm @ThomasRoehl @mrsimpson @janrudolph