[DO NOT MERGE]Feature/#145 ask question from room by vickyokrm · Pull Request #232 · assistify/Rocket.Chat

vickyokrm · 2018-02-14T21:40:54Z

closes #145 [Enable users to ask questions from an existing chat room]

Feature Overview:
To allow users to ask help about a conversation while they are in a chat room.

Motivation:
This feature will enable user to ask more questions in an isolated way which implies the new help request is created in the current conversation context.

Benefits of the solution:

Enable users to pro-actively communicate with out being afraid of leaving the chat room in which the user is conversing.
Using Assistify as a platform to ask and communicate more intensive.

What has changed/introduced:

A new Message Action so called 'Help' has been introduced shall be used to create help request for a particular message.
The new help request creation feature will prompt user to provide a request title a optional field.
Upon confirmation, a new help request room will be created propagating the experts users and the question/query to the new room.

What is missing:

Translation of the texts in Deutsch
Code review from reviewer
Feedback

… into feature/0.61

…to feature/#142-ask-question-from-room

vickyokrm · 2018-02-14T21:44:09Z

@ThomasRoehl @mrsimpson just realized that object from redlink:rocket-chat repo has messed my branch while pulling out test scripts updates.

ThomasRoehl · 2018-02-15T09:30:43Z

It is failing when looking for the last message in the request because there is none

[Help Reqeust]
	User not logged. logging in...
New Expertise created
    ✓ Create a Expertise (8329ms)
New Help Request Created
    ✓ Create a HelpRequest (8095ms)

  [In-Chat Help]
	Wrong logged user. Changing user...
Expertise already Exists
    ✓ Create a Expertise (663ms)
HelpRequest already Exists
    ✓ Create a HelpRequest (59ms)
    Help:
      1) "before all" hook


  4 passing (24s)
  1 failing

  1) [In-Chat Help]
       Help:
         "before all" hook:
     Uncaught Error: An element could not be located on the page using the given search parameters (".message:last-child .body").
      at moveToObject() - index.js:307:3

vickyokrm · 2018-02-18T21:17:42Z

@ThomasRoehl> Test scripts issues were fixed. Please do the needful.

ThomasRoehl

When the test is crashing after creating the topic and before writing the message, no further test run will be successful anymore.

ThomasRoehl · 2018-02-19T14:07:03Z

packages/assistify-help-request/server/methods/createRequest.js


-			return findAndModifyResult.value.value;
-		};
+class CreateRequestBase {


Is this rearrangement necessary? Did you check if your changes are adapted to all files which use this method?

@ThomasRoehl Yes, this is planned re-factoring.

ThomasRoehl · 2018-02-19T14:08:19Z

tests/end-to-end/ui/16-create-request.js

+import { checkIfUserIsValid, checkIfUserIsAdmin } from '../../data/checks';
+import globalObject from '../../pageobjects/global';
+const topicName = 'unit-testing';
+const message = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.';


The text is very long, for stability reasons you should take a shorter message

ThomasRoehl · 2018-02-19T14:08:52Z

tests/end-to-end/ui/16-create-request.js

+	describe('Help:', () => {
+		before(() => {
+			sideNav.spotlightSearch.waitForVisible(10000);
+			mainContent.openMessageActionMenu();


This is crashing if the topic exists but no message is there

ThomasRoehl · 2018-02-19T14:09:23Z

tests/pageobjects/assistify.page.js


-	get knowledgebasePostBtn() {
-		return browser.element('.external-search-content .smarti-widget .search-results .result-actions');
+	get knowledgebasePickAnswer() {


make sure you don't mess up other tests which use this functions

Basically, this has come from the redlink repo. So I just left it as is.

ThomasRoehl · 2018-02-19T14:10:43Z

tests/pageobjects/assistify.page.js

 	}

-	createHelpRequest(topicName, message) {
+	createHelpRequest(topicName, message, requestTitle) {


make sure you don't mess up other tests which use this functions.
Is it possible to call this function with only 2 parameters or do you have to add '' if no requestTitle is needed?

we would need to the function with 'requestTitle' because you would need to create a sub-request based on the requestTitle for tests scenario and when you do not pass the requestTitle it will be difficult figure out the request as it will get a random number.

…stify/Rocket.Chat into feature/#142-ask-question-from-room

ThomasRoehl · 2018-02-23T09:41:11Z

@vickyokrm I fixed the tests but found another bug:
when you try to use the help feature to create a new request, but the request already exists, there is no error or feedback to the user, it just skips the creation of the request. I don't think that is intended.

janrudolph · 2018-02-27T15:53:37Z

@vickyokrm and me reviewed the current state. Results:

Open new request works as expected :-)
We should add a bot message in the original channel after the new request has been created. the bot message should state that a new request has created based on the message. The message should contain the link to the request.
The "get help" dialog should have a member input field like the regular "channel create dialog". Thereby, an user is able to determine which other users should join the request. By default, all channel members should be listed. This feature is handy in large channels where not everyone wants to join a request by default.
Possible future enhancement (not part of this pull request): Assigning a topic to new requests. Thereby experts can be invited.

ruKurz · 2018-02-27T16:01:58Z

In a final version the request creation dialog should not appear to the user (asking a question). The name and users of the channel the user starts the question from shoul be taken as topic / experts. The display name of the newly created question can be set afterwards.

mrsimpson · 2018-02-27T17:58:45Z

@ruKurz @janrudolph your ideas about the target picture are opposite. I believe we should align it before @vickyokrm starts coding it

[Vigneshwaran Odayappan] added 5 commits February 7, 2018 16:02

retrieve chatpal-search submodule from assistify-repo

2029a2b

Merge branch 'feature/0.61' of https://github.com/assistify/Rocket.Chat…

e05d275

… into feature/0.61

Create help request room implicity from Chat Room

12bd2b5

Includes navigation and Factory instantiation

81cd4a1

Merge branch 'develop' of https://github.com/assistify/Rocket.Chat in…

8ced7e1

…to feature/#142-ask-question-from-room

ghost assigned vickyokrm Feb 14, 2018

ghost added the progress:working label Feb 14, 2018

vickyokrm requested review from ThomasRoehl and mrsimpson February 14, 2018 21:41

vickyokrm force-pushed the feature/#142-ask-question-from-room branch from c108dc2 to 54f0f14 Compare February 15, 2018 15:28

[Vigneshwaran Odayappan] added 3 commits February 15, 2018 17:22

removing unwanted files away

d02d130

add new fields to assistify page

3ad5ea2

execute tests with single login

f54ad56

vickyokrm force-pushed the feature/#142-ask-question-from-room branch from 54f0f14 to f54ad56 Compare February 18, 2018 20:21

ThomasRoehl suggested changes Feb 19, 2018

View reviewed changes

[Vigneshwaran Odayappan] and others added 3 commits February 22, 2018 10:08

adapting translation texts

61775ec

fixed test and moved to assistify folder

b596e65

Merge branch 'feature/#142-ask-question-from-room' of github.com:assi…

022a207

…stify/Rocket.Chat into feature/#142-ask-question-from-room

ghost assigned ThomasRoehl Feb 23, 2018

System message with navigation link

f26bd0d

vickyokrm changed the title ~~[DO NOT MERGE]Feature/#142 ask question from room~~ [DO NOT MERGE]Feature/#145 ask question from room Mar 4, 2018

vickyokrm closed this Mar 4, 2018

vickyokrm deleted the feature/#142-ask-question-from-room branch March 4, 2018 18:20

ghost removed the progress:working label Mar 4, 2018

vickyokrm mentioned this pull request Mar 4, 2018

Feature/#145 ask question from room #267

Merged

3 tasks

Conversation

vickyokrm commented Feb 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vickyokrm commented Feb 14, 2018

Uh oh!

ThomasRoehl commented Feb 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vickyokrm commented Feb 18, 2018

Uh oh!

ThomasRoehl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ThomasRoehl commented Feb 23, 2018

Uh oh!

janrudolph commented Feb 27, 2018

Uh oh!

ruKurz commented Feb 27, 2018

Uh oh!

mrsimpson commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vickyokrm commented Feb 14, 2018 •

edited

Loading

ThomasRoehl commented Feb 15, 2018 •

edited

Loading