Skip to content

Conversation

@duponter
Copy link
Contributor

Check List:

@scordio scordio self-assigned this Sep 22, 2025
@scordio scordio added this to the 3.27.6 milestone Sep 22, 2025
@scordio
Copy link
Member

scordio commented Sep 22, 2025

I sketched the following:

class ModuleDescriptor_Test {

  @Test
  void test() {
    // GIVEN
    Module underTest = ModuleLayer.boot().findModule("org.assertj.core").orElseThrow();
    // WHEN
    Set<String> packages = underTest.getPackages().stream().filter(p -> !p.contains("internal")).collect(toSet());
    // THEN
    then(packages).allMatch(underTest::isExported);
  }

}

It can be executed on main as module descriptors are handled appropriately, but we don't have a chance on 3.x as everything runs on the classpath and findModule("org.assertj.core") returns an empty optional.

I'm going ahead with the merge and will add the test above on main only, so that we can spot such issues when forward-porting changes.

@scordio scordio changed the title GH-3950: Added org.assertj.core.annotation to module exports Add missing export for org.assertj.core.annotation Sep 22, 2025
@scordio scordio merged commit e189652 into assertj:3.x Sep 22, 2025
17 checks passed
@scordio
Copy link
Member

scordio commented Sep 22, 2025

Thanks for your first contribution, @duponter!

@scordio scordio added the theme: module system An issue related to the Java module system label Sep 22, 2025
scordio added a commit that referenced this pull request Sep 22, 2025
scordio added a commit that referenced this pull request Sep 22, 2025
@duponter
Copy link
Contributor Author

You're welcome. But I should thank you for maintaining this fine library and the swift response to my bug ticket.

@duponter duponter deleted the bug/#3950 branch September 23, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: module system An issue related to the Java module system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants