Annotate fail methods with custom @Contract
#3882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30d0f26 to
9d9f8e6
Compare
This was referenced Aug 4, 2025
9d9f8e6 to
472d54b
Compare
jonatan-ivanov
pushed a commit
to scordio/micrometer
that referenced
this pull request
Aug 7, 2025
This commit configures org.assertj.core.internal.annotation.Contract as a custom contract annotation (added in AssertJ 3.27.4), using it fixes the previous issue with NullAway. See micrometer-metricsgh-6399 See micrometer-metricsgh-6589 See uber/NullAway#1222 See assertj/assertj#3882 See assertj/assertj#3880 Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
jonatan-ivanov
added a commit
to micrometer-metrics/micrometer
that referenced
this pull request
Aug 8, 2025
* Remove requireNonNull check from ObservationContextAssert This commit configures org.assertj.core.internal.annotation.Contract as a custom contract annotation (added in AssertJ 3.27.4), using it fixes the previous issue with NullAway. See gh-6399 See gh-6589 See uber/NullAway#1222 See assertj/assertj#3882 See assertj/assertj#3880 Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com> * Remove redundant requireNonNull from tests These issues were fixed in NullAway 0.12.8 See gh-6399 See gh-6589 See uber/NullAway#1219 See uber/NullAway#1224 See https://github.com/uber/NullAway/releases/tag/v0.12.8 --------- Closes gh-6399 Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com> Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Contractannotation to aid data flow analysis #3880