Skip to content

Conversation

@jh-instant
Copy link
Contributor

@jh-instant jh-instant commented Oct 17, 2024

Check List:

Hopefully fairly self explanatory. Happy to make any necessary changes. Not sure how to calculate the @since field on the Javadoc, so took a guess at the next minor version.

@joel-costigliola joel-costigliola self-requested a review October 19, 2024 21:58
@joel-costigliola joel-costigliola added this to the 3.27.0 milestone Oct 19, 2024
@jh-instant
Copy link
Contributor Author

Spotted the build was failing. Might be handy to have a bullet point to say "run ./mvnw spotless:apply" in the contributing doc - I wasn't aware this was a thing

@scordio
Copy link
Member

scordio commented Oct 25, 2024

Hi @jh-instant, thanks a lot for raising the PR! I'm sorry it might take a bit longer before we can review the changes.

If you participate in Hacktoberfest, I will label the PR as accepted so that it is properly counted.

@scordio scordio added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but we acknowledge it as an Hacktoberfest contribution label Oct 25, 2024
@jh-instant
Copy link
Contributor Author

No problem - take your time. Looks like I needed to rebase to fix this test:

[ERROR] DurationAssert_isZero_Test.should_fail_if_actual_is_not_zero:47
Expecting message to be:
"
expected: 0S
but was: -1S"
but was:
"
expected: 0S
but was: -1S"

I guess the workflows will need running again, sorry!

@joel-costigliola
Copy link
Member

Integrated thanks @jh-instant!

@scordio scordio changed the title Add predicate descriptions overloads to anyMatch and noneMatch Add predicate descriptions overloads to anyMatch and noneMatch Dec 14, 2024
nosan pushed a commit to nosan/assertj that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted We might not merge this PR before Nov 1st, but we acknowledge it as an Hacktoberfest contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow supplying predicate description to anyMatch and noneMatch

3 participants