Allow ComparingNormalizedFields instances to be reused across different assertions
#3493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, team!
After upgrading to 3.25.3 I see that
ComparingNormalizedFieldsRecursiveComparisonIntrospectionStrategycan't be between different assertions (see my example). I digged into the code and found that the change was introduced in commit 0d5b789, related to some performance improvements. The root cause is thatoriginalFieldNamesByNormalizedFieldNameByNodeis an identity hash map, althoughfieldNamesPerClassis keyed by class values. So, I found a fix for that, which I present here. I'm not sure that it's 100% correct, but I didn't find any failing tests. Hope you may find this helpful.Check List: