Skip to content

fix: fail lockfile translation for pnpm pnpm v9+ when no onlyBuildDependencies specified#1734

Merged
jbedard merged 1 commit into
aspect-build:2.xfrom
jbedard:pnpm-version-hook-check
May 15, 2024
Merged

fix: fail lockfile translation for pnpm pnpm v9+ when no onlyBuildDependencies specified#1734
jbedard merged 1 commit into
aspect-build:2.xfrom
jbedard:pnpm-version-hook-check

Conversation

@jbedard

@jbedard jbedard commented May 15, 2024

Copy link
Copy Markdown
Member

To ensure users always set onlyBuildDependencies for pnpm 9+ where we can not automatically detect lifecycle events from only the lockfile.

Test plan

  • Manual testing; please provide instructions so we can reproduce:

@jbedard jbedard requested a review from gregmagolan May 15, 2024 08:57
@aspect-workflows

aspect-workflows Bot commented May 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

190 tests (100.0%) were fully cached saving 51s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 845ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 773ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 511ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

8 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 393ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

Buildifier      Format

gregmagolan
gregmagolan reviewed May 15, 2024
View reviewed changes
Comment thread npm/private/npm_translate_lock_helpers.bzl Outdated
gregmagolan
gregmagolan reviewed May 15, 2024
View reviewed changes
Comment thread npm/private/npm_translate_lock_helpers.bzl Outdated
gregmagolan
gregmagolan approved these changes May 15, 2024
View reviewed changes

@gregmagolan gregmagolan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

This was referenced May 15, 2024
Closed
Open
@jbedard jbedard force-pushed the pnpm-version-hook-check branch from c6607b5 to 0b3495c Compare May 15, 2024 18:21
@jbedard jbedard enabled auto-merge (squash) May 15, 2024 18:23
@jbedard jbedard merged commit c4ebc84 into aspect-build:2.x May 15, 2024
@jbedard jbedard deleted the pnpm-version-hook-check branch May 15, 2024 19:24
jbedard added a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@jbedard
fix: fail lockfile translation for pnpm pnpm v9+ when no onlyBuildDep…
3fbc509 
…endencies specified (aspect-build#1734)
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard
fix: fail lockfile translation for pnpm pnpm v9+ when no onlyBuildDep…
b4e98df 
…endencies specified (#1734)
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard
fix: fail lockfile translation for pnpm pnpm v9+ when no onlyBuildDep…
28e8e98 
…endencies specified (#1734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @gregmagolan