Skip to content

refactor: set bazel_compatibility for bzlmod to >=6.0.0#1731

Merged
jbedard merged 1 commit into
2.xfrom
bazel_compat
May 15, 2024
Merged

refactor: set bazel_compatibility for bzlmod to >=6.0.0#1731
jbedard merged 1 commit into
2.xfrom
bazel_compat

Conversation

@gregmagolan

@gregmagolan gregmagolan commented May 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

We have dropped support for Bazel 5 in rules_js 2

@aspect-workflows

aspect-workflows Bot commented May 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

1 test target passed

Targets 
//docs:update_10_test [k8-fastbuild] 28ms

Total test execution time was 28ms. 189 tests (99.5%) were fully cached saving 51s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 845ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 773ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 511ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

8 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 393ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

Buildifier      Format

@gregmagolan gregmagolan mentioned this pull request May 15, 2024
Closed
21 tasks
@gregmagolan gregmagolan requested a review from jbedard May 15, 2024 02:27
@jbedard jbedard merged commit 121ae28 into 2.x May 15, 2024
@jbedard jbedard deleted the bazel_compat branch May 15, 2024 03:16
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
refactor: set bazel_compatibility for bzlmod to >=6.0.0 (aspect-build…
bdc47f4 
…#1731)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: set bazel_compatibility for bzlmod to >=6.0.0 (#1731)
47edcd5
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: set bazel_compatibility for bzlmod to >=6.0.0 (#1731)
63a2039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan @jbedard