Skip to content

feat: support pnpm.onlyBuiltDependencies#1723

Merged
jbedard merged 1 commit into
aspect-build:2.xfrom
jbedard:1689-only-build-deps
May 14, 2024
Merged

feat: support pnpm.onlyBuiltDependencies#1723
jbedard merged 1 commit into
aspect-build:2.xfrom
jbedard:1689-only-build-deps

Conversation

@jbedard

@jbedard jbedard commented May 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Suggested release notes appear below: yes

The pnpm.onlybuiltdependencies is now respected for lifecycle hooks. If specified only the packages listed in pnpm.onlybuiltdependencies will run lifecycle hooks.

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows

aspect-workflows Bot commented May 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

190 tests (100.0%) were fully cached saving 51s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 845ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 773ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 511ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 393ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

Buildifier      Format

@jbedard jbedard requested a review from gregmagolan May 14, 2024 07:00
@jbedard jbedard force-pushed the 1689-only-build-deps branch from aa4d0ce to e70a4ba Compare May 14, 2024 17:16
@jbedard jbedard marked this pull request as ready for review May 14, 2024 17:17
gregmagolan
gregmagolan reviewed May 14, 2024
View reviewed changes
Comment thread docs/pnpm.md Outdated
@jbedard jbedard force-pushed the 1689-only-build-deps branch 3 times, most recently from 195f3a5 to 4675241 Compare May 14, 2024 19:53
gregmagolan
gregmagolan reviewed May 14, 2024
View reviewed changes
Comment thread docs/pnpm.md
gregmagolan
gregmagolan approved these changes May 14, 2024
View reviewed changes

@gregmagolan gregmagolan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard mentioned this pull request May 14, 2024
Closed
21 tasks
@jbedard jbedard force-pushed the 1689-only-build-deps branch from 4675241 to 7c8f829 Compare May 14, 2024 20:55
@jbedard jbedard merged commit 4db6bd0 into aspect-build:2.x May 14, 2024
@jbedard jbedard deleted the 1689-only-build-deps branch May 14, 2024 21:23
@jbedard jbedard mentioned this pull request May 14, 2024
Closed
jbedard added a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@jbedard
feat: support pnpm.onlyBuiltDependencies (aspect-build#1723)
88cc71b
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard
feat: support pnpm.onlyBuiltDependencies (#1723)
26dac94
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard
feat: support pnpm.onlyBuiltDependencies (#1723)
541154f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @gregmagolan