Skip to content

refactor: change default linked target name to 'pkg'#1684

Merged
gregmagolan merged 1 commit into
2.xfrom
switch_link_package_default_name
Apr 26, 2024
Merged

refactor: change default linked target name to 'pkg'#1684
gregmagolan merged 1 commit into
2.xfrom
switch_link_package_default_name

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Apr 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

pkg is a better default for this compared to {dirname}, especially when running gazelle since it has trouble switching rules types if the default target of package is already a different rule and then that package is turned into a linkable package

@gregmagolan gregmagolan requested a review from jbedard April 25, 2024 12:08
@aspect-workflows

aspect-workflows Bot commented Apr 25, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

189 tests (100.0%) were fully cached saving 58s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 442ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 748ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 857ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 432ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 506ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

4 tests (100.0%) were fully cached saving 564ms.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 4s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 3s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 505ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 899ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 221ms.

Buildifier      Format

@gregmagolan gregmagolan force-pushed the switch_link_package_default_name branch from 463c835 to a777ff3 Compare April 25, 2024 12:12
@gregmagolan gregmagolan force-pushed the switch_link_package_default_name branch from a777ff3 to 6580445 Compare April 25, 2024 12:13
@gregmagolan gregmagolan force-pushed the switch_link_package_default_name branch from 6580445 to 13f4145 Compare April 25, 2024 12:26
@jbedard

jbedard commented Apr 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I think a test somewhere needs to be updated to use {dirname} so it's still tested? Or does that exist already somewhere?

jbedard
jbedard reviewed Apr 25, 2024
View reviewed changes
Comment thread npm/extensions.bzl
@gregmagolan gregmagolan merged commit c523192 into 2.x Apr 26, 2024
@gregmagolan gregmagolan deleted the switch_link_package_default_name branch April 26, 2024 21:00
gregmagolan added a commit that referenced this pull request Apr 26, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
e75d698
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
dc83039
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
c537b39
gregmagolan added a commit that referenced this pull request Apr 29, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
a4c7406
@gregmagolan gregmagolan mentioned this pull request Apr 29, 2024
Closed
21 tasks
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
065bf82
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
refactor: change default linked target name to 'pkg' (#1684)
91a339d
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
94c3a16
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
640b728
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
862cd33
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
3b59d81
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
90b9fef
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
refactor: change default linked target name to 'pkg' (#1684)
dbfc760
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
fc7f10a
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
54afb48
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
ab0c24a
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: change default linked target name to 'pkg' (aspect-build#1684)
17bd77f
jbedard pushed a commit that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: change default linked target name to 'pkg' (#1684)
44e0c9e
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
refactor: change default linked target name to 'pkg' (aspect-build#1684)
0e30611
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
6839f09
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: change default linked target name to 'pkg' (#1684)
0612e56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan @jbedard