Skip to content

refactor: rename gather_files_from_js_info to gather_files_from_js_infos#1665

Merged
gregmagolan merged 1 commit into
2.xfrom
gather_files_from_infos
Apr 19, 2024
Merged

refactor: rename gather_files_from_js_info to gather_files_from_js_infos#1665
gregmagolan merged 1 commit into
2.xfrom
gather_files_from_infos

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Very much a nit but since the function was renamed already may as well get the naming right before the 2.x release.

@aspect-workflows

aspect-workflows Bot commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

189 tests (100.0%) were fully cached saving 60s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 1s.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 857ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 91ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 91ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 435ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 188ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 432ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 393ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 239ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 1s.

Test

e2e/pnpm_lockfiles

All tests were cache hits

4 tests (100.0%) were fully cached saving 440ms.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 9s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 4s.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 899ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 447ms.

Buildifier      Format

@gregmagolan gregmagolan requested a review from jbedard April 19, 2024 21:48
@gregmagolan gregmagolan force-pushed the gather_files_from_infos branch from 6802ecf to e7c96fa Compare April 19, 2024 22:21
@gregmagolan gregmagolan merged commit 987cb21 into 2.x Apr 19, 2024
@gregmagolan gregmagolan deleted the gather_files_from_infos branch April 19, 2024 22:31
gregmagolan added a commit that referenced this pull request Apr 20, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
1916edc 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
4115fbd 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
ebf82da 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 22, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
6d30300 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 23, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
d22db3b 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 24, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
5329f60 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 26, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
34ac2b6 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
0a171bd 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
4bfe1f7 
…fos (#1665)
gregmagolan added a commit that referenced this pull request Apr 29, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
2b5eee3 
…fos (#1665)
@gregmagolan gregmagolan mentioned this pull request Apr 29, 2024
Closed
21 tasks
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
7a24538 
…fos (#1665)
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
c1186a4 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
d2a09ca 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
a135f74 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
fca901a 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
98ec9ec 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
ebaccf6 
…fos (#1665)
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
cbb2e7a 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
cd5ac3a 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
5537f0a 
…fos (#1665)
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
77b089a 
…fos (#1665)
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
9f66ba6 
…fos (aspect-build#1665)
jbedard pushed a commit that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
aa5024c 
…fos (#1665)
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
948d6b5 
…fos (aspect-build#1665)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
bb585b6 
…fos (#1665)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: rename gather_files_from_js_info to gather_files_from_js_in…
3130c79 
…fos (#1665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan @jbedard