Skip to content

refactor: don't gather files from NpmPackageStoreInfo providers in gather_files_from_js_info#1663

Merged
gregmagolan merged 1 commit into
2.xfrom
simplify_gather_files_from_js_info
Apr 19, 2024
Merged

refactor: don't gather files from NpmPackageStoreInfo providers in gather_files_from_js_info#1663
gregmagolan merged 1 commit into
2.xfrom
simplify_gather_files_from_js_info

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This was a bad pattern to pull from NpmPackageStoreInfo in the helper. Instead npm_package_store should just put its transitive files closure in DefaultInfo runfiles and also provide a JsInfo for when it is used directly in a js_run_binary or other js rules.

@aspect-workflows

aspect-workflows Bot commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

199 tests (100.0%) were fully cached saving 1m 1s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 1s.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 857ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 91ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 91ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 435ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 188ms.

Test

e2e/npm_translate_lock_subdir_patch

Buildkite build #3231 is running...

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 393ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 239ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 1s.

Test

e2e/pnpm_lockfiles

Waiting for runner...

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 9s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 4s.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 899ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 447ms.

Buildifier      Format

@gregmagolan gregmagolan force-pushed the simplify_gather_files_from_js_info branch from 3bfd482 to c177d2e Compare April 19, 2024 15:32
@gregmagolan gregmagolan requested a review from jbedard April 19, 2024 15:49
@gregmagolan gregmagolan marked this pull request as ready for review April 19, 2024 15:49
@gregmagolan gregmagolan marked this pull request as draft April 19, 2024 15:51
@gregmagolan gregmagolan force-pushed the simplify_gather_files_from_js_info branch from c177d2e to 0e267ad Compare April 19, 2024 16:11
@gregmagolan gregmagolan marked this pull request as ready for review April 19, 2024 16:36
@gregmagolan gregmagolan force-pushed the simplify_gather_files_from_js_info branch 2 times, most recently from c395f29 to 88826a2 Compare April 19, 2024 16:46
@gregmagolan gregmagolan force-pushed the simplify_gather_files_from_js_info branch from 88826a2 to 175a0fa Compare April 19, 2024 16:48
jbedard
jbedard reviewed Apr 19, 2024
View reviewed changes
Comment thread npm/private/npm_package_store.bzl
@jbedard

jbedard commented Apr 19, 2024

Copy link
Copy Markdown
Member

So we added the transitive_files_depset in 2 spots (JsInfo and DefaultInfo(runfiles)). Do we have tests verifying those are both required?

@gregmagolan gregmagolan merged commit 44f3b37 into 2.x Apr 19, 2024
@gregmagolan gregmagolan deleted the simplify_gather_files_from_js_info branch April 19, 2024 16:59
jbedard pushed a commit that referenced this pull request Apr 19, 2024
@gregmagolan @jbedard
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
a7a697d 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 20, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
aa93b55 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
3e9ad48 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
7bc0f96 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 22, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
43664a7 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 23, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
2c873cd 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 24, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
bd43d6b 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 26, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
f95f946 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
b3c02c5 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
6c9fc99 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request Apr 29, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
66e0622 
…ther_files_from_js_info (#1663)
@gregmagolan gregmagolan mentioned this pull request Apr 29, 2024
Closed
21 tasks
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
7a34e75 
…ther_files_from_js_info (#1663)
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
3179e94 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
328786c 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
62d1c4d 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
dd56198 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
87a88b5 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
9116d04 
…ther_files_from_js_info (#1663)
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
a695677 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
35a4c8d 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
0cd7680 
…ther_files_from_js_info (#1663)
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
8f3d95f 
…ther_files_from_js_info (#1663)
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
9a6c3a4 
…ther_files_from_js_info (aspect-build#1663)
jbedard pushed a commit that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
b874543 
…ther_files_from_js_info (#1663)
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
f473e43 
…ther_files_from_js_info (aspect-build#1663)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
867e41d 
…ther_files_from_js_info (#1663)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: don't gather files from NpmPackageStoreInfo providers in ga…
305480b 
…ther_files_from_js_info (#1663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan @jbedard