Why are these being added? What will they be used for?

Why are these being added? What will they be used for?

Read the summary

I know it's for #1646 and have looked at the code there as well, I was still hoping for more of an understanding of it though. There's no point merging this without understanding it first 🤷

I know it's for #1646 and have looked at the code there as well, I was still hoping for more of an understanding of it though. There's no point merging this without understanding it first 🤷

The code in #1646 is fairly easy to follow to find the use case. TL;DR is that in #1646 we're linking to a directory in the output tree so there is no File to get the path to that from. Instead we use a combination of the JsInfo bin_dir.path and the target.package to determine the directory path in the output tree to symlink to.

I would vote to only add these fields once we need them and they are actually used, so in the main PR. Want to change this PR just to do the re-ordering and fail cleanup?

I would vote to only add these fields once we need them and they are actually used, so in the main PR. Want to change this PR just to do the re-ordering and fail cleanup?

Sure. Updated.