refactor: rename include_npm_linked_packages to include_npm_sources && JsInfo npm_linked_packages to npm_sources#1623
Merged
Merged
Conversation
3c6f580 to
95c6fb2
Compare
102fae4 to
f79ba0d
Compare
ec6e3bd to
2627bc9
Compare
ed9433a to
e2545f5
Compare
…& JsInfo npm_linked_packages to npm_sources
e2545f5 to
a4b2ec8
Compare
jbedard
approved these changes
Apr 9, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 15, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 19, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
jbedard
pushed a commit
that referenced
this pull request
Apr 19, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 20, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 22, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 23, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 24, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 26, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
Apr 29, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 6, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
jbedard
pushed a commit
that referenced
this pull request
May 6, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
jbedard
pushed a commit
that referenced
this pull request
May 8, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 13, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 14, 2024
…& JsInfo npm_linked_packages to npm_sources (aspect-build#1623)
jbedard
pushed a commit
that referenced
this pull request
May 14, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 16, 2024
…& JsInfo npm_linked_packages to npm_sources (aspect-build#1623)
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
…& JsInfo npm_linked_packages to npm_sources (#1623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For JsInfo,
npm_sourcesis an improvement overnpm_linked_packagessince the field contains both npm package links as well as their transitive npm packages store Files. It is also more inline with thesourcesJsInfo field. Both are depsets of File withnpm_sourcesbeing all files undernode_modules.include_npm_linked_packagesrenamed toinclude_npm_sourcesto match.