refactor: move toolchain registration call to new rules_js_register_toolchains WORKSPACE function#1593
Merged
Conversation
07c2baa to
8937605
Compare
alexeagle
reviewed
Apr 3, 2024
alexeagle
reviewed
Apr 3, 2024
jbedard
reviewed
Apr 4, 2024
Member
|
What was the major reason for this? I don't recall if we've discussed it before? |
Member
Author
Primarily because we're sneaking in toolchain registrations in WORKSPACE in npm_translate_lock and npm_import which is not a great convention and bad layering. In theory a user could use rules_js without npm_translate_lock and npm_import and they would have to look into the implementation of npm_translate_lock to see what toolchains are needed. Adding an explicity |
a60a76e to
8527b49
Compare
9a40f81 to
4b5f986
Compare
e9ec6c3 to
33810af
Compare
…WORKSPACE function
jbedard
approved these changes
Apr 9, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
…WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
…WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 15, 2024
…WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 16, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 19, 2024
…oolchains WORKSPACE function (#1593)
jbedard
pushed a commit
that referenced
this pull request
Apr 19, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 20, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 22, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 23, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 24, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 26, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
Apr 29, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
May 6, 2024
…oolchains WORKSPACE function (#1593)
jbedard
pushed a commit
that referenced
this pull request
May 6, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…oolchains WORKSPACE function (#1593)
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
…oolchains WORKSPACE function (#1593)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long term this will all go away once we drop WORKSPACE support in our rule sets.