Skip to content

refactor: public API renames after review#159

Merged
gregmagolan merged 3 commits into
aspect-build:mainfrom
gregmagolan:public_api_review
Jun 3, 2022
Merged

refactor: public API renames after review#159
gregmagolan merged 3 commits into
aspect-build:mainfrom
gregmagolan:public_api_review

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Jun 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member
  • link_npm_* to npm_link_*
  • run_js_binary to js_run_binary
  • translate_pnpm_lock to npm_translate_lock

@gregmagolan gregmagolan marked this pull request as ready for review June 3, 2022 21:46
@gregmagolan gregmagolan changed the title refactor: rename link_npm_* to npm_link_* refactor: rename link_npm_* to npm_link_* and run_js_binary to js_run_binary Jun 3, 2022
@gregmagolan gregmagolan changed the title refactor: rename link_npm_* to npm_link_* and run_js_binary to js_run_binary refactor: public API renames after review Jun 3, 2022
@gregmagolan gregmagolan requested a review from alexeagle June 3, 2022 21:50
@gregmagolan gregmagolan merged commit 3e68169 into aspect-build:main Jun 3, 2022
gregmagolan pushed a commit that referenced this pull request Apr 20, 2024
chore: bump minimum bazel-lib version to 2.7.1
123d5f9 
Fixes #159
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
chore: bump minimum bazel-lib version to 2.7.1
dd2326b 
Fixes #159
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
chore: bump minimum bazel-lib version to 2.7.1
df42327 
Fixes #159
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
8063c6f 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request Apr 22, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
859ccaa 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request Apr 23, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
e20628b 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request Apr 24, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
ceafe83 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request Apr 26, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
db6805a 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
d7757bc 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
ef47b00 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request Apr 29, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
56f0f41 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
6b486ff 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
4edc8a6 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
bec2887 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
505bbbb 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
5150b3e 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
46eb46f 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
16c881e 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
a046631 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: set minimum aspect_bazel_lib to 2.7.1 (aspect-build#1580)
6b62fb2 
chore: bump minimum bazel-lib version to 2.7.1

Fixes aspect-build#159
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
refactor: set minimum aspect_bazel_lib to 2.7.1 (aspect-build#1580)
5d03dd9 
chore: bump minimum bazel-lib version to 2.7.1

Fixes aspect-build#159
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
0173ec6 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: set minimum aspect_bazel_lib to 2.7.1 (#1580)
04fdac9 
chore: bump minimum bazel-lib version to 2.7.1

Fixes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexeagle alexeagle alexeagle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan @alexeagle