refactor: drop support for Bazel 5#1589
Merged
Merged
Conversation
jbedard
reviewed
Apr 3, 2024
jbedard
reviewed
Apr 3, 2024
jbedard
reviewed
Apr 3, 2024
jbedard
reviewed
Apr 3, 2024
d22fd2c to
396b9db
Compare
gregmagolan
commented
Apr 3, 2024
alexeagle
approved these changes
Apr 3, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 4, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 6, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 7, 2024
jbedard
pushed a commit
that referenced
this pull request
Apr 9, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 9, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 13, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 15, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 19, 2024
jbedard
pushed a commit
that referenced
this pull request
Apr 19, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 20, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 21, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 22, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 23, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 24, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 26, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 28, 2024
gregmagolan
added a commit
that referenced
this pull request
Apr 29, 2024
gregmagolan
added a commit
that referenced
this pull request
May 6, 2024
jbedard
pushed a commit
that referenced
this pull request
May 6, 2024
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
gregmagolan
added a commit
that referenced
this pull request
May 7, 2024
jbedard
pushed a commit
that referenced
this pull request
May 8, 2024
gregmagolan
added a commit
that referenced
this pull request
May 10, 2024
gregmagolan
added a commit
that referenced
this pull request
May 13, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 14, 2024
jbedard
pushed a commit
to jbedard/rules_js
that referenced
this pull request
May 16, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
gregmagolan
added a commit
that referenced
this pull request
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping Bazel 5 support allows for many simplifications:
Assume that unresolved symlinks are supported (added in Bazel 6) so remove support for legacy
ctx.actions.declare_file+ctx.actions.symlinkin favor ofctx.actions.declare_symlink. Rules no longer have to take aunresolved_symlinks_enabledoruse_declare_symlinkparameter.Remove legacy node fs patches which were required for how Bazel 5 layed out symlinks in runfiles and the sandbox.
Remove all uses of consistent_label_str since Bazel 5 was the version with inconsistent labels compared to Bazel 6 & 7
We can assume labels that start with
@@are support since that support was added with bzlmod in Bazel 6