Skip to content

refactor: default include_runfiles to False in npm_package#1567

Merged
gregmagolan merged 1 commit into
2.xfrom
rjs_2
Apr 2, 2024
Merged

refactor: default include_runfiles to False in npm_package#1567
gregmagolan merged 1 commit into
2.xfrom
rjs_2

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This default was set wrong in rules_js 1.0. No reason to include runfiles in the potential files to copy into an npm_package by default.

@gregmagolan gregmagolan requested review from alexeagle and jbedard April 2, 2024 22:30
@gregmagolan gregmagolan merged commit b4cbe12 into 2.x Apr 2, 2024
@gregmagolan gregmagolan deleted the rjs_2 branch April 2, 2024 22:36
gregmagolan added a commit that referenced this pull request Apr 3, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
f4054da
gregmagolan added a commit that referenced this pull request Apr 3, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
89fc325
gregmagolan added a commit that referenced this pull request Apr 4, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
7def396
gregmagolan added a commit that referenced this pull request Apr 6, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
95c62e7
gregmagolan added a commit that referenced this pull request Apr 7, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
65a3a77
jbedard pushed a commit that referenced this pull request Apr 9, 2024
@gregmagolan @jbedard
refactor: default include_runfiles to False in npm_package (#1567)
13f52d8
gregmagolan added a commit that referenced this pull request Apr 9, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
6131436
gregmagolan added a commit that referenced this pull request Apr 13, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
8293d73
gregmagolan added a commit that referenced this pull request Apr 13, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
1aee1e1
gregmagolan added a commit that referenced this pull request Apr 15, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
a2370d2
gregmagolan added a commit that referenced this pull request Apr 19, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
69195c1
jbedard pushed a commit that referenced this pull request Apr 19, 2024
@gregmagolan @jbedard
refactor: default include_runfiles to False in npm_package (#1567)
1608691
gregmagolan added a commit that referenced this pull request Apr 20, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
8e8892d
gregmagolan added a commit that referenced this pull request Apr 21, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
ad7e66e
gregmagolan added a commit that referenced this pull request Apr 22, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
191a054
gregmagolan added a commit that referenced this pull request Apr 23, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
eb53b76
gregmagolan added a commit that referenced this pull request Apr 24, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
a168421
gregmagolan added a commit that referenced this pull request Apr 26, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
ea16a47
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
537cb94
gregmagolan added a commit that referenced this pull request Apr 28, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
6cd018e
@gregmagolan gregmagolan mentioned this pull request Apr 29, 2024
Closed
21 tasks
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
41994a9
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
refactor: default include_runfiles to False in npm_package (#1567)
0984d03
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
c694151
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
782e7b5
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
c5997c9
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
refactor: default include_runfiles to False in npm_package (#1567)
f104e7d
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
57113bc
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
605943c
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
refactor: default include_runfiles to False in npm_package (aspect-bu…
4842b78 
…ild#1567)
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
refactor: default include_runfiles to False in npm_package (aspect-bu…
ba9bad0 
…ild#1567)
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
97391f5
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
refactor: default include_runfiles to False in npm_package (#1567)
ab93dc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan @jbedard