fix(cli): unescape runfiles entries from manifest #799#800
Closed
ewhauser wants to merge 1 commit intoaspect-build:mainfrom
Closed
fix(cli): unescape runfiles entries from manifest #799#800ewhauser wants to merge 1 commit intoaspect-build:mainfrom
ewhauser wants to merge 1 commit intoaspect-build:mainfrom
Conversation
|
1b48a93 to
d91648e
Compare
jbedard
reviewed
Jan 22, 2025
d91648e to
8fcf3f9
Compare
8fcf3f9 to
64cc3fb
Compare
Member
|
Was there any progress on this? What was the reason for closing? |
Author
|
Left a comment on the ticket. This was a bug in |
Member
|
Ok, thanks for the info 👍 |
alexeagle
pushed a commit
to aspect-build/aspect-gazelle
that referenced
this pull request
Mar 17, 2025
…280) Internal implementation of aspect-build/aspect-cli#800 to handle changes introduced in bazel 7.4.0: bazelbuild/bazel#23912 Also attempt to handle relative paths that end up in the runfiles manifest --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes CLI outputs verb: Handle runfile characters [introduced in bazel 7.4.0](bazelbuild/bazel#23912) and attempt to determine an absolute path if a relative one is provided ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: I have tested this locally using the problem hit at Physical Intelligence: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1740690766072069
alexeagle
pushed a commit
to aspect-build/aspect-gazelle
that referenced
this pull request
Mar 18, 2025
…280) Internal implementation of aspect-build/aspect-cli#800 to handle changes introduced in bazel 7.4.0: bazelbuild/bazel#23912 Also attempt to handle relative paths that end up in the runfiles manifest --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes CLI outputs verb: Handle runfile characters [introduced in bazel 7.4.0](bazelbuild/bazel#23912) and attempt to determine an absolute path if a relative one is provided ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: I have tested this locally using the problem hit at Physical Intelligence: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1740690766072069
jbedard
pushed a commit
that referenced
this pull request
Apr 1, 2025
…280) Internal implementation of #800 to handle changes introduced in bazel 7.4.0: bazelbuild/bazel#23912 Also attempt to handle relative paths that end up in the runfiles manifest --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes CLI outputs verb: Handle runfile characters [introduced in bazel 7.4.0](bazelbuild/bazel#23912) and attempt to determine an absolute path if a relative one is provided ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: I have tested this locally using the problem hit at Physical Intelligence: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1740690766072069 GitOrigin-RevId: 94facf43fe480234860d4cc9073c62f7a095c245
jbedard
pushed a commit
that referenced
this pull request
Apr 1, 2025
…280) Internal implementation of #800 to handle changes introduced in bazel 7.4.0: bazelbuild/bazel#23912 Also attempt to handle relative paths that end up in the runfiles manifest --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes CLI outputs verb: Handle runfile characters [introduced in bazel 7.4.0](bazelbuild/bazel#23912) and attempt to determine an absolute path if a relative one is provided ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: I have tested this locally using the problem hit at Physical Intelligence: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1740690766072069 GitOrigin-RevId: 94facf43fe480234860d4cc9073c62f7a095c245
jbedard
pushed a commit
that referenced
this pull request
Apr 2, 2025
…280) Internal implementation of #800 to handle changes introduced in bazel 7.4.0: bazelbuild/bazel#23912 Also attempt to handle relative paths that end up in the runfiles manifest --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes CLI outputs verb: Handle runfile characters [introduced in bazel 7.4.0](bazelbuild/bazel#23912) and attempt to determine an absolute path if a relative one is provided ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: I have tested this locally using the problem hit at Physical Intelligence: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1740690766072069 GitOrigin-RevId: 94facf43fe480234860d4cc9073c62f7a095c245
alexeagle
pushed a commit
to aspect-build/aspect-gazelle
that referenced
this pull request
Jul 29, 2025
…280) Internal implementation of aspect-build/aspect-cli#800 to handle changes introduced in bazel 7.4.0: bazelbuild/bazel#23912 Also attempt to handle relative paths that end up in the runfiles manifest --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes CLI outputs verb: Handle runfile characters [introduced in bazel 7.4.0](bazelbuild/bazel#23912) and attempt to determine an absolute path if a relative one is provided ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: I have tested this locally using the problem hit at Physical Intelligence: https://aspect-build.slack.com/archives/C07TEJ68FAN/p1740690766072069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for aspect-build/aspect-cli-legacy#32