Remove unused lifetime parameter on SyntaxAndCache#714
Merged
GuillaumeGomez merged 1 commit intoaskama-rs:mainfrom Mar 24, 2026
Merged
Remove unused lifetime parameter on SyntaxAndCache#714GuillaumeGomez merged 1 commit intoaskama-rs:mainfrom
GuillaumeGomez merged 1 commit intoaskama-rs:mainfrom
Conversation
It's always 'static.
1a54f6f to
d6fd8ef
Compare
GuillaumeGomez
approved these changes
Mar 24, 2026
Collaborator
|
Simplification of lifetimes is welcome. :) Thanks! |
GuillaumeGomez
added a commit
that referenced
this pull request
Mar 24, 2026
Remove unused lifetime parameter on SyntaxAndCache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… that is always 'static.
Small refactor on the ways towards closing #594. In working on this, I realized that it will be a breaking change (not this PR, but
Syntaxwill have to change to hold eitherCow<'a, str>fields or plain owned types, I'm pretty sure).Let me know what you think about that.