parser: refactor |filter and {% filter %} parsing#500
Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom Jun 24, 2025
Merged
parser: refactor |filter and {% filter %} parsing#500Kijewski merged 2 commits intoaskama-rs:masterfrom
|filter and {% filter %} parsing#500Kijewski merged 2 commits intoaskama-rs:masterfrom
Conversation
Deduplicated and easier to read code.
GuillaumeGomez
previously approved these changes
Jun 24, 2025
Collaborator
|
The span location changed apparently. It doesn't seem to include the input and the "|" operator anymore. |
Member
Author
|
Changing the span was actually intentionally. IHMO including the left-hand side of the Do you dislike the change? |
GuillaumeGomez
approved these changes
Jun 24, 2025
Collaborator
|
As long as we have the "|" operator, I'm good. |
Member
Author
|
Oh, it's our PR #500! That's quite an underwhelming 500th PR. :D |
Collaborator
|
🎊 🎉 🥳 PS: My very nitpicky brain needs to address the "500th PR" part. On github, PR and issues share the same counter. That's it. 🤣 |
Member
Author
|
Oh, I forgot about that. :D 337th merged PR 🥳 🎉 |
Collaborator
|
🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicated and easier to read code.