Do not put question mark initialization expressions behind a reference#400
Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom Apr 12, 2025
Merged
Conversation
Kijewski
approved these changes
Apr 12, 2025
Member
Kijewski
left a comment
There was a problem hiding this comment.
@GuillaumeGomez, thank you for fixing the problem! @AMDmi3, thank you for reporting the problem!
|
Thanks a lot, this fixed my original problem! |
AMDmi3
added a commit
to repology/repology-rs
that referenced
this pull request
Apr 14, 2025
Askama git contains a fix for (probably a regression in 0.13 branch) which makes `?` operator add an extra reference level, which required adding extra derefs in templates. With latest askama we can get rid of these. See askama-rs/askama#399, askama-rs/askama#400.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #399.
I couldn't find any case where it would be an issue to add a reference so I suppose it's all good. :D