Update pom.xml to explicitly use commons-lang and a revised github api#162
Merged
ashwanthkumar merged 2 commits intoashwanthkumar:masterfrom Apr 29, 2021
Merged
Update pom.xml to explicitly use commons-lang and a revised github api#162ashwanthkumar merged 2 commits intoashwanthkumar:masterfrom
ashwanthkumar merged 2 commits intoashwanthkumar:masterfrom
Conversation
commons-lang has been deprecated and commons-lang3 is the latest. This commit explicitly pulls in commons-lang 2.6 which was the last in the earlier version. It is needed to build the plugin. The earlier v 1.68 for github-api is no longer available, and referencing v 1.128 enables the plugin to be built.
ashwanthkumar
approved these changes
Apr 29, 2021
Owner
ashwanthkumar
left a comment
There was a problem hiding this comment.
Except for that one comment, rest LGTM.
pom.xml
Outdated
| <version>1.3</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/commons-lang/commons-lang --> |
Owner
There was a problem hiding this comment.
Please consider removing this comment.
sriramnrn
added a commit
to sriramnrn/gocd-build-github-pull-requests
that referenced
this pull request
Apr 29, 2021
Merge pull request ashwanthkumar#162 from sriramnrn/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commons-lang has been deprecated and commons-lang3 is the latest. This commit explicitly pulls in commons-lang 2.6 which was the last in the earlier version. It is needed to build the plugin locally.
The earlier v 1.68 for github-api is no longer available, and referencing v 1.128 enables the plugin to be built.
This pull request doesn't yet migrate the plugin to use commons-lang3 (which I'm planning to raise as a separate PR).