Draw the Entry background in the delegate (fix #5520)#5643
Closed
ckaiser wants to merge 2 commits into
Closed
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Merged in 23ff825 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the approach to fixing #5520 and avoid #5628, depends on laf#170.
The cause of the bug was the double drawing of the background, once in the LAF side and once here but only when using TTF fonts with different bounds. I've moved the entirety of the drawing of the selection rect to this code, so it'll draw the right bounds in the delegate.