Add power of two sheet size flag on CLI #5529
Conversation
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
| Doc* lastDoc = nullptr; | ||
| render::DitheringAlgorithm ditheringAlgorithm = render::DitheringAlgorithm::None; | ||
| std::string ditheringMatrix; | ||
| bool powerOfTwoSize = false; |
There was a problem hiding this comment.
warning: variable 'powerOfTwoSize' of type 'bool' can be declared 'const' [misc-const-correctness]
| bool powerOfTwoSize = false; | |
| bool const powerOfTwoSize = false; |
adacefc to
1e42a1b
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
3bb8c00 to
a7b9828
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
a7b9828 to
81b4ee8
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
81b4ee8 to
2355d83
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
martincapello
left a comment
There was a problem hiding this comment.
LGTM! I left just a minor comment about the description, but it is not actually an issue, so feel free to leave it as is if you like yours.
| , m_sheetHeight( | ||
| m_po.add("sheet-height").requiresValue("<pixels>").description("Sprite sheet height")) | ||
| , m_powerOfTwoSize(m_po.add("power-of-two-size") | ||
| .description("Round up the size of the sprite sheet to a power of 2")) |
There was a problem hiding this comment.
I think I would change the description for something like:
"Round up the width and height of the sprite sheet to the nearest power of 2"
Added the CLI flag --power-of-two-size to round up the size of the sprite sheet to a power of 2.
2355d83 to
2fa98af
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I'll add a simple automatic test |
|
clang-tidy review says "All clean, LGTM! 👍" |
Fix #2289