Fix small graphical bug when dragging cels (fix #5216)#5471
Conversation
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
| case Range::kCels: { | ||
| gfx::Rect outlineBounds(dropBounds); | ||
| outlineBounds.enlarge(outlineWidth()); | ||
| int s = outlineWidth(); |
There was a problem hiding this comment.
warning: variable 's' of type 'int' can be declared 'const' [misc-const-correctness]
| int s = outlineWidth(); | |
| int const s = outlineWidth(); |
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
| return rc; | ||
| } | ||
|
|
||
| gfx::Rect Timeline::getPartBounds(const Hit& hit) const |
There was a problem hiding this comment.
warning: function 'getPartBounds' is within a recursive call chain [misc-no-recursion]
gfx::Rect Timeline::getPartBounds(const Hit& hit) const
^Additional context
src/app/ui/timeline/timeline.cpp:3205: example recursive call chain, starting from function 'getSelectedFramesBounds'
gfx::Rect Timeline::getSelectedFramesBounds(const Range& range) const
^src/app/ui/timeline/timeline.cpp:3209: Frame #1: function 'getSelectedFramesBounds' calls function 'getPartBounds' here:
rc |= getPartBounds(Hit(PART_HEADER_FRAME, 0, col_t(frame)));
^src/app/ui/timeline/timeline.cpp:3139: Frame #2: function 'getPartBounds' calls function 'getRangeBounds' here:
return getOutlinedRangeBounds(getRangeBounds(m_range));
^src/app/ui/timeline/timeline.cpp:3240: Frame #3: function 'getRangeBounds' calls function 'getSelectedFramesBounds' here:
case Range::kFrames: return getSelectedFramesBounds(range);
^src/app/ui/timeline/timeline.cpp:3240: ... which was the starting point of the recursive call chain; there may be other cycles
case Range::kFrames: return getSelectedFramesBounds(range);
^|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
No description provided.