Activate the native window before asking the user to save sprite changes#5318
Closed
ckaiser wants to merge 1 commit into
Closed
Activate the native window before asking the user to save sprite changes#5318ckaiser wants to merge 1 commit into
ckaiser wants to merge 1 commit into
Conversation
Collaborator
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Works great! LGTM👍 Before seeing anything, I thought it might interfere with the floating windows, but no. From what I've tested, they work fine. |
dacap
pushed a commit
that referenced
this pull request
Aug 26, 2025
Member
|
Cherry picked as 49fa352 (updated laf module + added issue reference in the commit message) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3542
Comes with some changes to LAF (aseprite/laf#153) so that the behavior of
activate()matches the other platforms, although for some reason testing this on Windows I'm having an entirely different bug where the no events are getting through to the app when it's minimized and I can't reproduce it on the stable version. This is unrelated to these changes and needs some more testing.