Add 'Show hidden' check to file selector#5269
Merged
Merged
Conversation
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| double zoom() const { return m_zoom; } | ||
| void setZoom(const double zoom); | ||
| void animateToZoom(const double zoom); | ||
| void setShowHidden(const bool show); |
Collaborator
There was a problem hiding this comment.
warning: parameter 'show' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| void setShowHidden(const bool show); | |
| void setShowHidden(bool show); |
Member
|
It works great @Liebranca 👍 I'll merge it as it is and then fix some issue on Windows to handle special hidden files. Later we'll think in an alternative icon for this button, but I'm not sure what to use yet. |
dacap
added a commit
that referenced
this pull request
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a checkbox to control showing hidden files in file selector window. Fix #3079.