Support CJK input#5230
Conversation
|
Hi there! One or more of the commit messages in this PR do not match our code submission policy, please check the |
83df582 to
66b1166
Compare
b73fba1 to
0e4abdb
Compare
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
|
@Cerallin I've updated the main branch of aseprite to include laf changes, if you rebase your PR and force push the commits, you should have the required changes to pass the checks in this PR. |
174f703 to
82d7c03
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@Cerallin there are a couple of errors: 1) I've merged the laf changes and now the main branch of aseprite doesn't compile it, so I'll fix it, but 2) the signed CLA doesn't include the email address used in the commits of the PR. The first change I'll push will make the PR to have conflicts with the main branch. |
|
OK，I will sign the CLA and solve the conflicts tonight. |
This method is for Entry::setTextInput() and IME positioning.
82d7c03 to
e01bd48
Compare
e01bd48 to
f04678e
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Thanks @Cerallin 👍 I was able to test this and it works great. There is an issue with the Text tool where pressing the Enter key in the IME dialog will finish the Text tool entry, but I'll try to fix that for the release. |
|
@dacap Thank you very much! I was busy these days, but I will keep up with IME/CJK-display related issues when I am available. There are some minor issues about IME positioning to be fixed, I will create an issue or a PR later. And then I may work with IME support on Linux. (I don't have a mac so I can't help there.) |
|
Thank you @Cerallin, I think this is huge first step for most users (which are on Windows platforms). Any other help and PR will be welcomed! |
With #5230, now that we can show the IME dialog on Windows, when we are selecting a specific word/composition in the IME dialog, if we press Enter we'll receive that Enter onKeyUp(). It's better if we process the Enter key onKeyDown() (as the IME enter key is not received in that case).
This PR will be a draft until aseprite/laf#147 is merged.
Ref: #1767
I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md
I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing