Skip to content

Fix marquee tool escape deselection#5145

Merged
dacap merged 1 commit into
aseprite:mainfrom
JoshuaL03:fix-marquee-tool-escape
Aug 25, 2025
Merged

Fix marquee tool escape deselection#5145
dacap merged 1 commit into
aseprite:mainfrom
JoshuaL03:fix-marquee-tool-escape

Conversation

@JoshuaL03

@JoshuaL03 JoshuaL03 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Fix #5102.

This PR fixes an issue when pressing the escape key in the marquee tool. Instead of deselecting the selection, it should now undo the movement and match the functionality of the X button.

I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing

@JoshuaL03 JoshuaL03 requested a review from dacap as a code owner April 25, 2025 21:34
@dacap dacap self-assigned this Jun 10, 2025
@dacap

dacap commented Aug 25, 2025

Copy link
Copy Markdown
Member

Thanks @JoshuaL03, I think the best will be to merge this PR as it matches the tooltip (Esc = the X button). Anyway I'm worried that this behavior change might impact some current users, so I'll check if we can add an option (probably right-clicking the X button) to customize the behavior.

@dacap dacap merged commit debab65 into aseprite:main Aug 25, 2025
@dacap dacap added this to the v1.3.15 milestone Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pressing Escape in the marquee tool deselects instead of canceling drag and drop

2 participants