Add support to use mouse buttons (including X1 & X2) as shortcuts (fix #598) by dacap · Pull Request #4927 · aseprite/aseprite

dacap · 2025-01-10T14:48:36Z

This is a work-in-progress to fix #598

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2025-01-10T14:53:35Z

-                                      const KeyboardShortcuts& globalKeys,
-                                      const KeyContext keyContext) const
+const ui::Shortcut* Key::isPressed(const Message* msg,
+                                   const KeyboardShortcuts& globalKeys,


warning: parameter 'globalKeys' is unused [misc-unused-parameters]

Suggested change

const KeyboardShortcuts& globalKeys,

const KeyboardShortcuts& /*globalKeys*/,

aseprite-bot

clang-tidy made some suggestions

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2025-01-23T20:27:11Z

+{
+  bool state = (checkbox->isSelected());
+  KeyModifiers modifiers = m_shortcut.modifiers();
+  KeyScancode scancode = m_shortcut.scancode();


warning: variable 'scancode' of type 'KeyScancode' (aka 'os::KeyScancode') can be declared 'const' [misc-const-correctness]

Suggested change

KeyScancode scancode = m_shortcut.scancode();

KeyScancode const scancode = m_shortcut.scancode();

aseprite-bot · 2025-01-23T20:27:12Z

+  alt()->setSelected(m_shortcut.modifiers() & kKeyAltModifier ? true : false);
+  ctrl()->setSelected(m_shortcut.modifiers() & kKeyCtrlModifier ? true : false);
+  shift()->setSelected(m_shortcut.modifiers() & kKeyShiftModifier ? true : false);
+  space()->setSelected(m_shortcut.modifiers() & kKeySpaceModifier ? true : false);


warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]

space()->setSelected(m_shortcut.modifiers() & kKeySpaceModifier ? true : false); ^

this fix will not be applied because it overlaps with another fix

aseprite-bot · 2025-01-23T20:27:12Z

+  alt()->setSelected(m_shortcut.modifiers() & kKeyAltModifier ? true : false);
+  ctrl()->setSelected(m_shortcut.modifiers() & kKeyCtrlModifier ? true : false);
+  shift()->setSelected(m_shortcut.modifiers() & kKeyShiftModifier ? true : false);
+  space()->setSelected(m_shortcut.modifiers() & kKeySpaceModifier ? true : false);


warning: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr]

Suggested change

space()->setSelected(m_shortcut.modifiers() & kKeySpaceModifier ? true : false);

space()->setSelected((m_shortcut.modifiers() & kKeySpaceModifier) != 0);

aseprite-bot · 2025-01-23T20:27:12Z

+    "Also known as Windows key, logo key,\ncommand key, or system key.",
+    TOP);
+  #endif
+  win()->setSelected(m_shortcut.modifiers() & kKeyWinModifier ? true : false);


warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]

win()->setSelected(m_shortcut.modifiers() & kKeyWinModifier ? true : false); ^

this fix will not be applied because it overlaps with another fix

aseprite-bot · 2025-01-23T20:27:12Z

+    "Also known as Windows key, logo key,\ncommand key, or system key.",
+    TOP);
+  #endif
+  win()->setSelected(m_shortcut.modifiers() & kKeyWinModifier ? true : false);


warning: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr]

Suggested change

win()->setSelected(m_shortcut.modifiers() & kKeyWinModifier ? true : false);

win()->setSelected((m_shortcut.modifiers() & kKeyWinModifier) != 0);

aseprite-bot

clang-tidy made some suggestions

…seprite#1793)

Without this patch assigning the same mouse button shortcut to a command would delete its assignment at all.

aseprite-bot

clang-tidy made some suggestions

aseprite-bot · 2025-12-05T19:32:37Z

  }
 }

+bool StandbyState::handleDragActionsFromMessage(Editor* editor, const ui::Message* msg)


warning: method 'handleDragActionsFromMessage' can be made static [readability-convert-member-functions-to-static]

src/app/ui/editor/standby_state.h:58:

- bool handleDragActionsFromMessage(Editor* editor, const ui::Message* msg); + static bool handleDragActionsFromMessage(Editor* editor, const ui::Message* msg);

aseprite-bot · 2025-12-05T19:32:37Z

 }

-Keys KeyboardShortcuts::getDragActionsFromKeyMessage(const ui::Message* msg)
+Keys KeyboardShortcuts::getDragActionsFromMessage(const ui::Message* msg)


warning: method 'getDragActionsFromMessage' can be made static [readability-convert-member-functions-to-static]

src/app/ui/keyboard_shortcuts.h:78:

- Keys getDragActionsFromMessage(const ui::Message* msg); + static Keys getDragActionsFromMessage(const ui::Message* msg);

dacap self-assigned this Jan 10, 2025

aseprite-bot reviewed Jan 10, 2025

View reviewed changes

dacap linked an issue Jan 10, 2025 that may be closed by this pull request

Make special mouse buttons customizable #598

Closed

dacap force-pushed the new-shortcuts branch from 3978d37 to 50c5f9d Compare January 23, 2025 19:40

aseprite-bot reviewed Jan 23, 2025

View reviewed changes

Comment thread src/ui/manager.cpp

dacap force-pushed the new-shortcuts branch from 50c5f9d to 9106c64 Compare January 23, 2025 20:21

aseprite-bot reviewed Jan 23, 2025

View reviewed changes

dacap force-pushed the new-shortcuts branch from 9106c64 to b24bf1d Compare February 7, 2025 18:14

dacap mentioned this pull request Apr 17, 2025

Add option to reassign mouse buttons #5127

Open

dacap mentioned this pull request Jun 2, 2025

Rename ui::Accelerator to ui::Shortcut #5190

Merged

dacap force-pushed the new-shortcuts branch from b24bf1d to d185681 Compare June 10, 2025 20:39

dacap force-pushed the new-shortcuts branch 2 times, most recently from d4c2bbb to b1da5f8 Compare September 1, 2025 21:37

dacap force-pushed the new-shortcuts branch from b1da5f8 to 1e34821 Compare October 3, 2025 14:28

dacap force-pushed the new-shortcuts branch 2 times, most recently from 0996744 to e96ad18 Compare December 4, 2025 15:22

aseprite-bot reviewed Dec 4, 2025

View reviewed changes

Comment thread src/app/ui/doc_view.cpp Outdated

Comment thread src/app/ui/doc_view.cpp Outdated

Comment thread src/app/ui/keyboard_shortcuts.cpp Outdated

dacap force-pushed the new-shortcuts branch from e96ad18 to 053f5f2 Compare December 5, 2025 16:13

Add support to use mouse buttons as shortcuts (fix aseprite#598, fix a…

ae69e2d

…seprite#1793)

dacap force-pushed the new-shortcuts branch from d193657 to a03baf4 Compare December 5, 2025 18:30

dacap added 2 commits December 5, 2025 15:42

Add possibility to use a quick tool with any mouse button (+ modifiers)

62eaf01

Fix bug reassigning the same mouse button shortcuts

a73c54f

Without this patch assigning the same mouse button shortcut to a command would delete its assignment at all.

dacap force-pushed the new-shortcuts branch from a03baf4 to e96fbdb Compare December 5, 2025 18:56

dacap marked this pull request as ready for review December 5, 2025 19:32

aseprite-bot reviewed Dec 5, 2025

View reviewed changes

dacap added 2 commits December 5, 2025 16:42

Add some extra const-correctness

2dd0cda

Add support to drag values pressing a mouse button

11e4ec4

dacap force-pushed the new-shortcuts branch from 61ba443 to 11e4ec4 Compare December 5, 2025 19:43

dacap merged commit 8d48b43 into aseprite:beta Dec 5, 2025
12 checks passed

dacap deleted the new-shortcuts branch December 5, 2025 19:48

dacap mentioned this pull request Feb 4, 2026

Replicate the Right Click configuration on Keyboard Shortcuts menu #5646

Open

2 tasks

	const KeyboardShortcuts& globalKeys,
	const KeyboardShortcuts& /globalKeys/,

	KeyScancode scancode = m_shortcut.scancode();
	KeyScancode const scancode = m_shortcut.scancode();

	space()->setSelected(m_shortcut.modifiers() & kKeySpaceModifier ? true : false);
	space()->setSelected((m_shortcut.modifiers() & kKeySpaceModifier) != 0);

	win()->setSelected(m_shortcut.modifiers() & kKeyWinModifier ? true : false);
	win()->setSelected((m_shortcut.modifiers() & kKeyWinModifier) != 0);

Uh oh!

Uh oh!

Conversation

dacap commented Jan 10, 2025

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aseprite-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants