Skip to content

fix(vue): add transform to props list#437

Merged
kodiakhq[bot] merged 1 commit intoascorbic:mainfrom
huang-julien:fix/vue/transformerprops
Jan 6, 2024
Merged

fix(vue): add transform to props list#437
kodiakhq[bot] merged 1 commit intoascorbic:mainfrom
huang-julien:fix/vue/transformerprops

Conversation

@huang-julien
Copy link
Contributor

Hello 👋

This PR fix #436 and fix nuxt-modules/cloudinary#181 .

When using useAttrs(), it doesn't disable attribute inheritance in a vue component. Since transformer isn't declared as a prop, vue will try to render it as an attribute.

It doesn't matter server-side thanks to vue/server-renderer which clean the html. However there's no cleaning client-side so vue will render transformer as an attribute.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-solid ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-solid/deploys/6599320c0881390008cf6ef9
😎 Deploy Preview https://deploy-preview-437--unpic-solid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-qwik ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-qwik/deploys/6599320c96369e00085a86b1
😎 Deploy Preview https://deploy-preview-437--unpic-qwik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-svelte ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-svelte/deploys/6599320cb0e4610008524a4f
😎 Deploy Preview https://deploy-preview-437--unpic-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-astro ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-astro/deploys/6599320c5baa3c0008033263
😎 Deploy Preview https://deploy-preview-437--unpic-astro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-vue ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-vue/deploys/6599320c8b43510008a824ec
😎 Deploy Preview https://deploy-preview-437--unpic-vue.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-next ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-next/deploys/6599320c1c7f4e0008ac5238
😎 Deploy Preview https://deploy-preview-437--unpic-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-angular ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-angular/deploys/6599320c305c4f0008df6172
😎 Deploy Preview https://deploy-preview-437--unpic-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-docs ready!

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-docs/deploys/6599320ca6928e00088c7979
😎 Deploy Preview https://deploy-preview-437.preview.unpic.pics
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-preact canceled.

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-preact/deploys/6599320ccc15e50008ac6034

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-lit ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-lit/deploys/6599320c767c360008c6c28d
😎 Deploy Preview https://deploy-preview-437--unpic-lit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for unpic-webc ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c86853
🔍 Latest deploy log https://app.netlify.com/sites/unpic-webc/deploys/6599320d9a76e00008283a56
😎 Deploy Preview https://deploy-preview-437--unpic-webc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thanks for fixing this

@kodiakhq kodiakhq bot merged commit 0dae7c1 into ascorbic:main Jan 6, 2024
@mixie-bot mixie-bot bot mentioned this pull request Jan 6, 2024
kodiakhq bot pushed a commit that referenced this pull request Jan 6, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>vue: 0.0.42</summary>

## [0.0.42](vue-v0.0.41...vue-v0.0.42) (2024-01-06)


### Bug Fixes

* **vue:** add transform to props list ([#437](#437)) ([0dae7c1](0dae7c1))
</details>

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformer is rendered as attributes in @unpic/vue Transformer function is rendered as html attribute when mounted client-side

2 participants