Added support for Solaris / illumos#1018
Merged
Merged
Conversation
Owner
|
Thanks for raising this. Looks good to me! Wonder if it is worth mentioning in https://github.com/ascopes/protobuf-maven-plugin/blob/main/protobuf-maven-plugin/src/site/markdown/changing-protoc-versions.md or the examples page in the same directory. What do you think, would that be useful do you think? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
+ Coverage 94.09% 94.10% +0.02%
==========================================
Files 78 78
Lines 2044 2048 +4
Branches 129 131 +2
==========================================
+ Hits 1923 1927 +4
Misses 85 85
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Always happy to document things! What kind of documentation were you thinking about? Some documentation about how to deloy self-built protoc binaries and how to use them with the plugin? |
Owner
|
@siepkes I was originally just thinking about the mention of the fact that platforms like Solaris are now supported so long as a custom build is provided... however, the idea of having a separate page that documents how to go about actually building that would be pretty cool too! |
This change adds support for using the plugin on illumos and Solaris. While there is no official protoc artifact in Maven central, it's quite easy to build protoc for Solaris.
Contributor
Author
|
I've added some documentation. Let me know what you think about it! |
Owner
|
LGTM, thanks! |
Owner
|
Will push in a release in a few mins, should be on Maven Central for consumption in the next hour or so hopefully. |
mergify Bot
added a commit
to ArcadeData/arcadedb
that referenced
this pull request
Jun 29, 2026
…to 5.1.6 [skip ci] Bumps [io.github.ascopes:protobuf-maven-plugin](https://github.com/ascopes/protobuf-maven-plugin) from 5.1.5 to 5.1.6. Release notes *Sourced from [io.github.ascopes:protobuf-maven-plugin's releases](https://github.com/ascopes/protobuf-maven-plugin/releases).* > v5.1.6 > ------ > > What's Changed > -------------- > > * Forbid unused imports by [`@ascopes`](https://github.com/ascopes) in [ascopes/protobuf-maven-plugin#1017](https://redirect.github.com/ascopes/protobuf-maven-plugin/pull/1017) > * Bump actions/checkout from 6 to 7 by [`@dependabot`](https://github.com/dependabot)[bot] in [ascopes/protobuf-maven-plugin#1019](https://redirect.github.com/ascopes/protobuf-maven-plugin/pull/1019) > * Added support for Solaris / illumos by [`@siepkes`](https://github.com/siepkes) in [ascopes/protobuf-maven-plugin#1018](https://redirect.github.com/ascopes/protobuf-maven-plugin/pull/1018) > > New Contributors > ---------------- > > * [`@siepkes`](https://github.com/siepkes) made their first contribution in [ascopes/protobuf-maven-plugin#1018](https://redirect.github.com/ascopes/protobuf-maven-plugin/pull/1018) > > **Full Changelog**: <ascopes/protobuf-maven-plugin@v5.1.5...v5.1.6> Commits * [`7bf0941`](ascopes/protobuf-maven-plugin@7bf0941) [maven-release-plugin] prepare release v5.1.6 * [`f05fe86`](ascopes/protobuf-maven-plugin@f05fe86) Merge pull request [#1018](https://redirect.github.com/ascopes/protobuf-maven-plugin/issues/1018) from siepkes/solaris-support * [`c932d26`](ascopes/protobuf-maven-plugin@c932d26) Added support for Solaris / illumos * [`21bb21b`](ascopes/protobuf-maven-plugin@21bb21b) Merge pull request [#1019](https://redirect.github.com/ascopes/protobuf-maven-plugin/issues/1019) from ascopes/dependabot/github\_actions/main/actions/... * [`3c22c18`](ascopes/protobuf-maven-plugin@3c22c18) Bump actions/checkout from 6 to 7 * [`25529ac`](ascopes/protobuf-maven-plugin@25529ac) Merge pull request [#1017](https://redirect.github.com/ascopes/protobuf-maven-plugin/issues/1017) from ascopes/task/forbid-unused-imports * [`72c4cda`](ascopes/protobuf-maven-plugin@72c4cda) Forbid unused imports * [`a9f9e6c`](ascopes/protobuf-maven-plugin@a9f9e6c) [maven-release-plugin] prepare for next development iteration * See full diff in [compare view](ascopes/protobuf-maven-plugin@v5.1.5...v5.1.6) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for using the plugin on illumos and Solaris.
While there is no official protoc artifact in Maven central, it's quite easy to build protoc for Solaris and deploy it to a local repository. For example using a command like:
I've tested the plugin with this change on illumos.