Fixes for building Orange Pi One on Debian Sid (fixes #321, fixes #319)#322
Merged
igorpecovnik merged 3 commits intoarmbian:masterfrom May 27, 2016
Merged
Fixes for building Orange Pi One on Debian Sid (fixes #321, fixes #319)#322igorpecovnik merged 3 commits intoarmbian:masterfrom
igorpecovnik merged 3 commits intoarmbian:masterfrom
Conversation
| # parttype[nfs] is empty | ||
|
|
||
| mkopts[ext4]='-q -m 2' | ||
| mkopts[ext4]='-O ^64bit,^metadata_csum,uninit_bg -q -m 2' |
Member
There was a problem hiding this comment.
@igorpecovnik
Quick test shows that this will break image building on Trusty hosts because older mkfs.ext4 desn't know about 64bit and metadata_csum options.
Contributor
Author
There was a problem hiding this comment.
@zador-blood-stained the only thing to test that I can try Docker, but I'm not sure if will not hit #318
Member
There was a problem hiding this comment.
NO_APT_CACHER=yes parameter handling should be fixed, but this doesn't change the fact that these ext4 options break build process on Trusty (which is still declared as a compatible build host) and it's too early to drop Trusty support IMO since AFAIK Trusty->Xenial upgrade will be available after 16.04.1 release (scheduled at the end of July).
igorpecovnik
added a commit
that referenced
this pull request
May 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below 3 patches contain fixes that I had to apply to build bootable Orage Pi One image on Debian Sid.