Fix Mergify checks hanging when rules don't apply#4670
Merged
Conversation
The first rule's conditions required Lookout UI files to be present, which prevented the check from completing on PRs without UI changes. Move the file path conditions into success_conditions so the check always runs and succeeds immediately when no Lookout UI files are modified. Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
Move file path conditions from rule conditions into success_conditions so checks always run and return success when they don't apply. Rule 1 (Lookout UI): Succeeds if no Lookout UI files, or approval requirements met. Rule 2 (Armada maintainers): Succeeds if only Lookout UI files, or approval requirements met. Frontend-only maintainers can self-approve pure Lookout UI changes but require 2 approvals or an Armada maintainer for any backend changes. Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
JamesMurkin
approved these changes
Feb 6, 2026
pavlovic-ivan
approved these changes
Feb 6, 2026
dslear
pushed a commit
to dslear/armada
that referenced
this pull request
Feb 9, 2026
Move file path conditions from rule conditions into success_conditions so checks always run and return success when they don't apply. Rule 1 (Lookout UI): Succeeds if no Lookout UI files, or approval requirements met. Rule 2 (Armada maintainers): Succeeds if only Lookout UI files, or approval requirements met. Frontend-only maintainers can self-approve pure Lookout UI changes but require 2 approvals or an Armada maintainer for any backend changes. --------- Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move file path conditions from rule conditions into success_conditions
so checks always run and return success when they don't apply.
Rule 1 (Lookout UI): Succeeds if no Lookout UI files, or approval
requirements met.
Rule 2 (Armada maintainers): Succeeds if only Lookout UI files, or
approval requirements met.
Frontend-only maintainers can self-approve pure Lookout UI changes but
require 2 approvals or an Armada maintainer for any backend changes.