Merged
Conversation
We're comparing strings, we don't get an extra validation by looking up the default priority class name Medium term we should make Priority include the priority name - Then we could just check that matches and that already does the defaulting Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
mauriceyap
approved these changes
Feb 6, 2026
dslear
pushed a commit
to dslear/armada
that referenced
this pull request
Feb 9, 2026
We're comparing strings, we don't get an extra validation by looking up the default priority class name Medium term we should make Priority include the priority name - Then we could just check that matches and that already does the defaulting Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're comparing strings, we don't get an extra validation by looking up the default priority class name
Medium term we should make Priority include the priority name