[Lookout UI] Submit dialogs on enter#4649
Merged
mauriceyap merged 2 commits intoarmadaproject:masterfrom Feb 3, 2026
Merged
Conversation
Signed-off-by: David.Burkhalter <d2.burkhalter@gmail.com>
mauriceyap
reviewed
Jan 29, 2026
| const selectedJobsCount = selectedJobs.length | ||
| return ( | ||
| <Dialog open={true} onClose={onClose} fullWidth maxWidth="xl"> | ||
| <Dialog open={true} onClose={onClose} fullWidth maxWidth="xl" onKeyDown={handleDialogKeyDown}> |
Collaborator
There was a problem hiding this comment.
Could this instead be achieved by passing the props component="form" onSubmit={handleSubmit} to the <Dialog> here? If it does, the button below with type="submit" should hopefully take effect since it's inside this rendered <form> component and so we'd be able to remove handleDialogKeyDown.
mauriceyap
approved these changes
Feb 2, 2026
geaere
approved these changes
Feb 3, 2026
dslear
pushed a commit
to dslear/armada
that referenced
this pull request
Feb 9, 2026
#### What type of PR is this? Lookout UI enhancement #### What this PR does / why we need it Allows users to press enter to submit dialogs for canceling and reprioritizing jobs. Signed-off-by: David.Burkhalter <d2.burkhalter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Lookout UI enhancement
What this PR does / why we need it
Allows users to press enter to submit dialogs for canceling and reprioritizing jobs.