[Lookout UI] Adding Copy All Button to Job ID Column#4648
Merged
mauriceyap merged 13 commits intoarmadaproject:masterfrom Feb 3, 2026
Merged
[Lookout UI] Adding Copy All Button to Job ID Column#4648mauriceyap merged 13 commits intoarmadaproject:masterfrom
mauriceyap merged 13 commits intoarmadaproject:masterfrom
Conversation
8049d81 to
478366a
Compare
mauriceyap
reviewed
Feb 2, 2026
| textOverflow: "ellipsis", | ||
| whiteSpace: "nowrap", | ||
| overflow: "hidden", | ||
| <div |
Collaborator
There was a problem hiding this comment.
This change has removed the conditional check for header.column.getCanSort(). The <TableSortLabel> component is now rendered unconditionally for all columns, including non-sortable ones. Please could you restore the conditional rendering so that <TableSortLabel> is only used when header.column.getCanSort() returns true?
Comment on lines
+173
to
+179
| style={{ | ||
| display: "flex", | ||
| flexDirection: "row", | ||
| alignItems: "center", | ||
| gap: 6, | ||
| whiteSpace: "nowrap", | ||
| }} |
Collaborator
There was a problem hiding this comment.
I think we still need overflow: 'hidden' here to prevent potential layout issues when content overflows e.g. long header text. Was there a visual reason why you removed this?
Collaborator
Author
There was a problem hiding this comment.
The goal was to make sure that the copy button did not disappear when then column was resized to minimized width. Was able to restore coverflow hidden in this commit
Comment on lines
+98
to
+106
| // job ID copy values | ||
| const isJobIdColumn = header.column.id === StandardColumnId.JobID | ||
| const jobsTable = header.getContext().table | ||
| const visibleRows = jobsTable.getRowModel().rows | ||
| const visibleRowsExist = visibleRows.length > 0 | ||
| const allJobIds = visibleRows | ||
| .map((row) => row.original.jobId) | ||
| .filter(Boolean) | ||
| const copyContent = allJobIds.join(", ") |
Collaborator
There was a problem hiding this comment.
This is logically correct, but I think this would be slightly cleaner
Suggested change
| // job ID copy values | |
| const isJobIdColumn = header.column.id === StandardColumnId.JobID | |
| const jobsTable = header.getContext().table | |
| const visibleRows = jobsTable.getRowModel().rows | |
| const visibleRowsExist = visibleRows.length > 0 | |
| const allJobIds = visibleRows | |
| .map((row) => row.original.jobId) | |
| .filter(Boolean) | |
| const copyContent = allJobIds.join(", ") | |
| const copyContent = header.column.id === StandardColumnId.JobID | |
| ? header.getContext().table.getRowModel().rows | |
| .map((row) => row.original.jobId) | |
| .filter(Boolean) | |
| .join(", ") | |
| : "" |
| const remainingWidth = totalWidth - resizerWidth - borderWidth | ||
|
|
||
| // job ID copy values | ||
| const isJobIdColumn = header.column.id === StandardColumnId.JobID |
Collaborator
There was a problem hiding this comment.
This would be better if it were a configuration value in GET_JOB_COLUMNS() in internal/lookoutui/src/common/jobsTableColumns.tsx - perhaps:
accessorColumn({
id: StandardColumnId.JobID,
// ...
additionalMetadata: {
// ...
allowCopyColumn: true,
}
})
added 6 commits
February 2, 2026 13:39
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
added 3 commits
February 2, 2026 13:54
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
mauriceyap
previously approved these changes
Feb 3, 2026
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
MustafaI
approved these changes
Feb 3, 2026
mauriceyap
approved these changes
Feb 3, 2026
dslear
pushed a commit
to dslear/armada
that referenced
this pull request
Feb 9, 2026
) Adds a button in the jobID column of the Lookout UI to copy all visible Job IDs on the current page. This eliminates the need for users to copy IDs individually. I made minor changes to the HeaderTableCell attributes to ensure that the button remains visible when the column is resized to the minimum width. --------- Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai> Co-authored-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it
This PR adds a button in the jobID column of the Lookout UI to copy all visible Job IDs on the current page. This eliminates the need for users to copy IDs individually. I made minor changes to the HeaderTableCell attributes to ensure that the button remains visible when the column is resized to the minimum width.
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer