Detect jobs on deleted nodes during run reconciliation#4622
Merged
mauriceyap merged 5 commits intomasterfrom Jan 27, 2026
Merged
Detect jobs on deleted nodes during run reconciliation#4622mauriceyap merged 5 commits intomasterfrom
mauriceyap merged 5 commits intomasterfrom
Conversation
Previously, the reconciler only checked for pool/reservation mismatches on existing nodes. Jobs assigned to nodes that no longer exist were silently ignored, leaving them in an invalid state.
Now the reconciler builds a set of current node IDs and fails reconciliation for any job whose assigned node is missing. This ensures orphaned jobs are properly marked as failed rather than remaining in limbo.
Also fixes typos in error messages ("this jobs" -> "this job's", "resevation" -> "reservation").
Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
dejanzele
reviewed
Jan 26, 2026
dejanzele
previously approved these changes
Jan 26, 2026
nikola-jokic
previously approved these changes
Jan 27, 2026
Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk>
JamesMurkin
approved these changes
Jan 27, 2026
Sigele
pushed a commit
to Sigele/armada
that referenced
this pull request
Jan 30, 2026
…#4622) Previously, the reconciler only checked for pool/reservation mismatches on existing nodes. Jobs assigned to nodes that no longer exist were silently ignored, leaving them in an invalid state. Now the reconciler builds a set of current node IDs and fails reconciliation for any job whose assigned node is missing. This ensures orphaned jobs are properly marked as failed rather than remaining in limbo. Also fixes typos in error messages ("this jobs" -> "this job's", "resevation" -> "reservation"). --------- Signed-off-by: Maurice Yap <mauriceyap@hotmail.co.uk> Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the reconciler only checked for pool/reservation mismatches on existing nodes. Jobs assigned to nodes that no longer exist were silently ignored, leaving them in an invalid state.
Now the reconciler builds a set of current node IDs and fails reconciliation for any job whose assigned node is missing. This ensures orphaned jobs are properly marked as failed rather than remaining in limbo.
Also fixes typos in error messages ("this jobs" -> "this job's", "resevation" -> "reservation").