feat: validate ports across init containers and fix native sidecar resource calculation#4615
Merged
dejanzele merged 2 commits intoarmadaproject:masterfrom Jan 21, 2026
Conversation
…source calculation Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
26fcf3a to
a4adcc1
Compare
JamesMurkin
approved these changes
Jan 21, 2026
Sigele
pushed a commit
to Sigele/armada
that referenced
this pull request
Jan 30, 2026
…source calculation (armadaproject#4615) <!-- Thanks for sending a pull request! Here are some tips for you: --> #### What type of PR is this? Enhancement and bug fix #### What this PR does / why we need it - Extends port validation to include init containers, detecting duplicate ports across all container types - Fixes resource calculation for native sidecar init containers (`RestartPolicy=Always`) to sum their resources with main containers instead of using `max()` #### Which issue(s) this PR fixes <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_* --> Fixes # #### Special notes for your reviewer Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com> Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement and bug fix
What this PR does / why we need it
RestartPolicy=Always) to sum their resources with main containers instead of usingmax()Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer