Re-enable away scheduling for gang jobs#4614
Merged
JamesMurkin merged 1 commit intomasterfrom Jan 21, 2026
Merged
Conversation
This was originally disabled due to a bug that caused gangs to get partially scheduled Since that change we have largely rewritten how gang jobs are modelled internally in the scheduler so we believe this bug is now fixed - I've added several unit tests around this around, targeting what we believe was cause of the bug (scheduled and preempted in the same round) I have added `DisableGangAwayScheduling` as: - If the bug is still there, it allows us to disable the feature again with a config change - Some configurations, it wouldn't be suitable for gang jobs to be scheduled away as these are typically more volatile (inclined to be preempted) and this isn't always suitable for gangs Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com>
MustafaI
approved these changes
Jan 21, 2026
Sigele
pushed a commit
to Sigele/armada
that referenced
this pull request
Jan 30, 2026
This was originally disabled due to a bug that caused gangs to get partially scheduled Since that change we have largely rewritten how gang jobs are modelled internally in the scheduler so we believe this bug is now fixed - I've added several unit tests around this around, targeting what we believe was cause of the bug (scheduled and preempted in the same round) I have added `DisableGangAwayScheduling` as: - If the bug is still there, it allows us to disable the feature again with a config change - Some configurations, it wouldn't be suitable for gang jobs to be scheduled away as these are typically more volatile (inclined to be preempted) and this isn't always suitable for gangs Signed-off-by: JamesMurkin <jamesmurkin@hotmail.com> Signed-off-by: Sigele Nickerson-Adams <sigele.nickerson-adams@nmc2.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally disabled due to a bug that caused gangs to get partially scheduled
Since that change we have largely rewritten how gang jobs are modelled internally in the scheduler so we believe this bug is now fixed
I have added
DisableGangAwaySchedulingas: