[ATfE] Update comment about handling cleanup for exit()#679
Merged
voltur01 merged 1 commit intoarm:arm-softwarefrom Jan 16, 2026
Merged
[ATfE] Update comment about handling cleanup for exit()#679voltur01 merged 1 commit intoarm:arm-softwarefrom
voltur01 merged 1 commit intoarm:arm-softwarefrom
Conversation
smithp35
approved these changes
Jan 16, 2026
Contributor
smithp35
left a comment
There was a problem hiding this comment.
Code changes LGTM.
Could you give a brief description for the commit message so we know what the update is from git log.
Something like:
The original comment had a TODO to implement cleanup like calling cxa_finalize. It turns
out that this is already done by LLVM libc's exit() so we can remove the TODO.
Contributor
Author
|
Will do, thank you! |
voltur01
added a commit
to voltur01/arm-toolchain
that referenced
this pull request
Jan 21, 2026
This removes the TODO comment to implement cleanup like calling cxa_finalize. It was confirmed and captured in the updated comment that this is already done by LLVM libc's exit() implementation. (cherry picked from commit 3872774)
voltur01
added a commit
that referenced
this pull request
Jan 22, 2026
This applies the following changes to 22.x release branch: #667 [ATfE] Use semihosting SYS_READC for stdin with llvm libc #676 [ATfE] Remove __LLVM_LIBC__ define workaround for libcxx #678 [ATfE] Replace call to abort with __llvm_libc_exit in libc startup code #679 [ATfE] Update comment about handling cleanup for exit() #683 [ATfE] Provide nohost init and exit in llvmlibc startup code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.