Conversation
Add Focus::Details to the Models tab, allowing users to navigate to the detail panel with h/l/Tab and scroll its content with j/k/g/G/Ctrl+d/u. - Add ScrollOffset-based detail_scroll to ModelsApp - Replace SwitchFocus with directional FocusModelLeft/FocusModelRight - Refactor draw_model_detail from fixed Layout+Tables to Vec<Line> + ScrollablePanel for scrollable, focus-aware rendering - Reset detail scroll on model change (navigation, sort, filter, search) - Update style guide: mark known inconsistency #3 as fixed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add BenchmarkFocus::Details to the Benchmarks tab, allowing users to navigate to the detail panel with h/l/Tab and scroll with j/k/g/G/Ctrl+d/u. - Add ScrollOffset-based detail_scroll to BenchmarksApp - Replace switch_focus with directional focus_right/focus_left methods - Refactor draw_benchmark_detail to use ScrollablePanel with focus-aware border coloring and scrollbar - Extract build_benchmark_detail_lines for reuse by detail overlay - Reset detail scroll on selection change, filter, sort, and rebuild - Update tests for new directional focus API - Update style guide: mark known inconsistency #4 as fixed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
arimxyer
added a commit
that referenced
this pull request
Mar 20, 2026
* Models tab: make detail panel navigable and scrollable Add Focus::Details to the Models tab, allowing users to navigate to the detail panel with h/l/Tab and scroll its content with j/k/g/G/Ctrl+d/u. - Add ScrollOffset-based detail_scroll to ModelsApp - Replace SwitchFocus with directional FocusModelLeft/FocusModelRight - Refactor draw_model_detail from fixed Layout+Tables to Vec<Line> + ScrollablePanel for scrollable, focus-aware rendering - Reset detail scroll on model change (navigation, sort, filter, search) - Update style guide: mark known inconsistency #3 as fixed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Benchmarks tab: make detail panel navigable and scrollable Add BenchmarkFocus::Details to the Benchmarks tab, allowing users to navigate to the detail panel with h/l/Tab and scroll with j/k/g/G/Ctrl+d/u. - Add ScrollOffset-based detail_scroll to BenchmarksApp - Replace switch_focus with directional focus_right/focus_left methods - Refactor draw_benchmark_detail to use ScrollablePanel with focus-aware border coloring and scrollbar - Extract build_benchmark_detail_lines for reuse by detail overlay - Reset detail scroll on selection change, filter, sort, and rebuild - Update tests for new directional focus API - Update style guide: mark known inconsistency #4 as fixed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * style: fix formatting in models detail render Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h/l/Tabcycles through Providers → Models → Details, withj/k/g/G/Ctrl+d/Ctrl+ufor scrollingh/l/Tabcycles through Creators → List → DetailsChanges
Focus::Detailsto Models tab withScrollOffset-based scrollingBenchmarkFocus::Detailsto Benchmarks tab withScrollOffset-based scrollingdraw_model_detailfrom fixedLayout+Tablewidgets toVec<Line>+ScrollablePaneldraw_benchmark_detailto useScrollablePanelwith extractedbuild_benchmark_detail_linesswitch_focuswith directionalfocus_left/focus_righton both tabsTest plan
mise run clippypasses clean🤖 Generated with Claude Code