Removing useless asynchronism in packaged mode.#27
Merged
divdavem merged 6 commits intoariatemplates:masterfrom Nov 6, 2014
Merged
Removing useless asynchronism in packaged mode.#27divdavem merged 6 commits intoariatemplates:masterfrom
divdavem merged 6 commits intoariatemplates:masterfrom
Conversation
When loading a packaged module with a synchronous request, the loaded module was not synchronously available because some asynchronism was added in the promises chain. This commit fixes this issue.
8420f7e to
fd88c86
Compare
fd88c86 to
e3c46b6
Compare
5cd0b74 to
5b55082
Compare
Mobile Safari 6.0.0 (iOS 6.0) executes tests in loop, without stopping, as shown on the following build log: https://travis-ci.org/ariatemplates/noder-js/builds/40178104
Member
|
9979c32 seems ok for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a packaged module with a synchronous request, the loaded module was not synchronously available because some asynchronism was added in the promises chain. This commit fixes this issue.