Possibility to update the packagesMap config#21
Merged
flongo merged 1 commit intoariatemplates:masterfrom Jul 18, 2014
Merged
Conversation
flongo
added a commit
to flongo/noder-js
that referenced
this pull request
Jul 17, 2014
Introduction of an API (`noder.updatePackagesMap`) that allows to update the packagesMap after noder has been already initialized. Close ariatemplates#21
flongo
added a commit
to flongo/noder-js
that referenced
this pull request
Jul 17, 2014
Introduction of an API (`noder.updatePackagesMap`) that allows to update the packagesMap after noder has been already initialized. Close ariatemplates#21
build/visitors/NoderMap.js
Outdated
Member
There was a problem hiding this comment.
I think it is better to write it this way:
var map = this.toFile ? {} : configUtils.getPackagesMap(packaging, this.noderConfig, this.noderContext);I don't understand why it would be needed to have 2 different variables map and outputMap, but maybe I am missing something, and I suppose there is no need to call getPackagesMap when toFile is provided.
Member
|
The travis build is failing because sources were probably not formatted with the grunt |
doc/packaging.md
Outdated
Member
There was a problem hiding this comment.
Note: there is an extra back-quote before the which badly formats part of this text.
flongo
added a commit
to flongo/noder-js
that referenced
this pull request
Jul 17, 2014
Introduction of an API (`noder.updatePackagesMap`) that allows to update the packagesMap after noder has been already initialized. Close ariatemplates#21
flongo
added a commit
to flongo/noder-js
that referenced
this pull request
Jul 17, 2014
Introduction of an API (`noder.updatePackagesMap`) that allows to update the packagesMap after noder has been already initialized. Close ariatemplates#21
Member
|
🆗 f6eaa57 seems fine for me Perhaps it would be good to add a test for |
flongo
added a commit
to flongo/noder-js
that referenced
this pull request
Jul 17, 2014
Introduction of an API (`noder.updatePackagesMap`) that allows to update the packagesMap after noder has been already initialized. Close ariatemplates#21
Introduction of an API (`noder.updatePackagesMap`) that allows to update the packagesMap after noder has been already initialized. Close ariatemplates#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction of an API (
noder.updatePackagesMap) that allows to update the packagesMap after noder has been already initialized.