update GACOS function to agree with MintPy's#340
Merged
bbuzzanga merged 2 commits intoaria-tools:sss_raidersupfrom Jan 23, 2023
Merged
update GACOS function to agree with MintPy's#340bbuzzanga merged 2 commits intoaria-tools:sss_raidersupfrom
bbuzzanga merged 2 commits intoaria-tools:sss_raidersupfrom
Conversation
Collaborator
|
Is this using the incidence angle in aria tools rather than look angle?
…On Sun, Jan 22, 2023 at 4:41 PM BB ***@***.***> wrote:
This changes the resampling algorithm to use the default for interpolating
the GACOS product to the ARIA crop. It also removes some unnecessary
masking. After these changes, we agree within numerical precision to the
GACOS correction written with MintPy (note I had to do some internal
hacking to output a single SLC date and inverted units to compare with
MintPy from aria tools)
After this PR:
[image: Screenshot 2023-01-22 at 16 36 54]
<https://user-images.githubusercontent.com/15522503/213949329-148d9a52-3b1d-4b34-9452-adf127bb9f13.png>
Before this PR:
[image: Screenshot 2023-01-21 at 15 01 15]
<https://user-images.githubusercontent.com/15522503/213949339-9725358a-c63f-42a3-a06a-7b17922b9e02.png>
Units are in meters.
------------------------------
You can view, comment on, or merge this pull request online at:
#340
Commit Summary
- 08bf802
<08bf802>
update GACOS function to agree with MintPy's
File Changes
(1 file <https://github.com/aria-tools/ARIA-tools/pull/340/files>)
- *M* tools/ARIAtools/extractProduct.py
<https://github.com/aria-tools/ARIA-tools/pull/340/files#diff-0825983d8f602546eceb6ec0829b23f8b437e3c3dac00d13ab7872127794b883>
(73)
Patch Links:
- https://github.com/aria-tools/ARIA-tools/pull/340.patch
- https://github.com/aria-tools/ARIA-tools/pull/340.diff
—
Reply to this email directly, view it on GitHub
<#340>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESZPSLSFRRBECX4Y5M6KZLWTXHTLANCNFSM6AAAAAAUDJCNP4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Collaborator
Author
|
Yes this uses the incidence angle |
sssangha
approved these changes
Jan 23, 2023
Collaborator
sssangha
left a comment
There was a problem hiding this comment.
All looks good on my end
Collaborator
|
@sssangha the unit test seems to fail. This might be more related to something else that you are fixing on your end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the resampling algorithm to use the default for interpolating the GACOS product to the ARIA crop. It also removes some unnecessary masking. After these changes, we agree within numerical precision to the GACOS correction written with MintPy (note I had to do some internal hacking to output a single SLC date and inverted units to compare with MintPy from aria tools)
After this PR:
Before this PR:
Units are in meters.