Coverage remained the same at 97.917% when pulling e8122ba on m31271n:master into c5d4447 on ardumont:master.

Hi,

Thanks for the effort. I'm not sure to understand though.

Do you have some sample so that i could see what this actually solve?

Cheers,

Thanks for your reply.

For example, I have a title like "配置 SPF（Sender Policy Framework）记录"。

The old markdown-toc--to-link is:

(defun markdown-toc--to-link (title)
  "Given a TITLE, return the markdown link associated."
  (format "[%s](#%s)" title
          (->> title
               downcase
               (replace-regexp-in-string "[^a-z0-9 -]" "")
               (s-replace " " "-"))))

Call it with the title:

(markdown-toc--to-link "配置 SPF（Sender Policy Framework）记录")
;; Eval it, we get "[配置 SPF（Sender Policy Framework）记录](#-spfsender-policy-framework)"

The UTF-8 characters disappear.

(defun markdown-toc--to-link (title)
  "Given a TITLE, return the markdown link associated."
  (format "[%s](#%s)" title
          (->> title
               downcase
               (replace-regexp-in-string "[[:punct:]]" "")
               (s-replace " " "-"))))

Call it with the title, too:

(markdown-toc--to-link "配置 SPF（Sender Policy Framework）记录")
;; Eval it, we get "[配置 SPF（Sender Policy Framework）记录](#配置-spfsender-policy-framework记录)"

The UTF-8 characters are still here.

Wow, yes, that's a problem.
Thanks for the details.

Will take a closer look as soon as i can.

Cheers,

When I'll merge the 0.1.1 branch, this PR will be closed.
I've cherry-picked your commit and iterated over it to fix the edge case.
Some title contains - which were removed.

Thanks for raising this up and proposing a fix!
Awesome!

Cheers,

You are welcome. ;]

This fix with @ardumont 's edge handling works perfectly in Japanese markdown text I'm writing! Thanks a lot for both of you, @ardumont and @m31271n 👍

@shino @m31271n Thanks for the reminder.
I'll update markdown-toc soon ^^

This fix with @ardumont 's edge handling works perfectly in Japanese markdown text I'm writing! Thanks a lot for both of you, @ardumont and @m31271n 👍

@shino Also, thanks for providing yet another feedback, it's awesome.

Cheers,

Cheers.